Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more follow ups to caveats in datastore #906

Merged
merged 4 commits into from
Oct 18, 2022
Merged

more follow ups to caveats in datastore #906

merged 4 commits into from
Oct 18, 2022

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Oct 17, 2022 •
edited
Loading

  • adds exhaustive testing of CREATE/TOUCH semantics
  • add variadic caveat list to ListCaveats
  • make WriteCaveat serialize the whole CaveatDefinition proto instead of just the serialized bytes

@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Oct 17, 2022
@vroldanbet vroldanbet self-assigned this Oct 17, 2022
@vroldanbet vroldanbet marked this pull request as ready for review October 17, 2022 19:24
@vroldanbet vroldanbet requested a review from a team October 17, 2022 19:24
josephschorr
josephschorr reviewed Oct 17, 2022
View reviewed changes
pkg/datastore/caveat.go Outdated Show resolved Hide resolved
internal/datastore/postgres/caveat.go Show resolved Hide resolved
@vroldanbet vroldanbet force-pushed the more-caveat-datastore-followups branch 2 times, most recently from e886193 to e37ff25 Compare October 18, 2022 08:06
josephschorr
josephschorr approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

josephschorr
josephschorr previously approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet force-pushed the more-caveat-datastore-followups branch from e37ff25 to 4a764ab Compare October 18, 2022 17:42
@vroldanbet vroldanbet force-pushed the more-caveat-datastore-followups branch from 4a764ab to d29c133 Compare October 18, 2022 17:49
@vroldanbet vroldanbet enabled auto-merge October 18, 2022 17:55
josephschorr
josephschorr approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vroldanbet vroldanbet merged commit acfe39a into main Oct 18, 2022
@vroldanbet vroldanbet deleted the more-caveat-datastore-followups branch October 18, 2022 18:06
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephschorr josephschorr josephschorr approved these changes

Assignees

@vroldanbet vroldanbet

Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vroldanbet @josephschorr