Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elide updates of namespaces which have not changed at all #913

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

josephschorr
Copy link
Member

Should reduce some of the write work when updating larger schemas and produces less garbage

Fixes #902

@josephschorr josephschorr requested review from vroldanbet and a team October 18, 2022 21:22
@github-actions github-actions bot added area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Oct 18, 2022
@vroldanbet
Copy link
Contributor

@josephschorr please address merge conflicts to proceed with review 🙏🏻

@vroldanbet vroldanbet marked this pull request as draft October 20, 2022 08:21
@josephschorr josephschorr marked this pull request as ready for review October 20, 2022 15:35
Copy link
Contributor

@vroldanbet vroldanbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just few questions

internal/services/v1/schema.go Outdated Show resolved Hide resolved
internal/services/v1/schema.go Show resolved Hide resolved
vroldanbet
vroldanbet previously approved these changes Oct 25, 2022
@josephschorr
Copy link
Member Author

Rebased

Should reduce some of the write work when updating larger schemas and produces less garbage

Fixes authzed#902
@vroldanbet vroldanbet enabled auto-merge October 26, 2022 08:17
@vroldanbet vroldanbet merged commit cf6a777 into authzed:main Oct 26, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/api v1 Affects the v1 API area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate eliding updates of namespaces unchanged in schema write
2 participants