EPD-621 Updates for CI #5
Conversation
|
gonna put this back in draft mode, gonna leave it open while i work on the other pieces |
nicolewhite
force-pushed
the
nicole/epd-621-send-git-metadata-from-cli
branch
4 times, most recently
from
f07840b to
1a3481a
Compare
|
hello |
nicolewhite
force-pushed
the
nicole/epd-621-send-git-metadata-from-cli
branch
3 times, most recently
from
c8e389d to
d167a04
Compare
nicolewhite
force-pushed
the
nicole/epd-621-send-git-metadata-from-cli
branch
from
d167a04 to
d29b6c9
Compare
| function pullRequestFromEvent(event: unknown): PullRequest | null { | ||
| const parsed = zPullRequestSchema.safeParse(event); | ||
| if (parsed.success) { | ||
| return parsed.data; | ||
| } | ||
| return null; | ||
| } |
There was a problem hiding this comment.
should we log the error here?
There was a problem hiding this comment.
no because failures are expected for events that aren't pull request events (like push and schedule)
nicolewhite
force-pushed
the
nicole/epd-621-send-git-metadata-from-cli
branch
2 times, most recently
from
b3fb261 to
c67382e
Compare
nicolewhite
force-pushed
the
nicole/epd-621-send-git-metadata-from-cli
branch
3 times, most recently
from
99be702 to
93f822d
Compare
nicolewhite
force-pushed
the
nicole/epd-621-send-git-metadata-from-cli
branch
from
93f822d to
20e5096
Compare
| } | ||
| if (!this.ciContext) { | ||
| try { | ||
| this.ciContext = await makeCIContext(); |
There was a problem hiding this comment.
Was a bit confused on first read through about what this was doing and how it wasn't a function naming conflicts - but I see this works because the maxCIContext you are defining here is a instance member and what you are calling on line 114 is an import.
There was a problem hiding this comment.
Ah yeah I see, any rename suggestions are welcome 😁
| gitProvider: ciContext.gitProvider, | ||
| repositoryExternalId: ciContext.repoId, | ||
| repositoryName: ciContext.repoName, | ||
| repositoryHtmlUrl: ciContext.repoHtmlUrl, | ||
| branchExternalId: ciContext.branchId, | ||
| branchName: ciContext.branchName, | ||
| isDefaultBranch: ciContext.branchName === ciContext.defaultBranchName, | ||
| ciProvider: ciContext.ciProvider, | ||
| buildHtmlUrl: ciContext.buildHtmlUrl, | ||
| commitSha: ciContext.commitSha, | ||
| commitMessage: ciContext.commitMessage, | ||
| commitCommitterName: ciContext.commitCommitterName, | ||
| commitCommitterEmail: ciContext.commitCommitterEmail, | ||
| commitAuthorName: ciContext.commitAuthorName, | ||
| commitAuthorEmail: ciContext.commitAuthorEmail, | ||
| commitCommittedDate: ciContext.commitCommittedDate, | ||
| pullRequestNumber: ciContext.pullRequestNumber, | ||
| pullRequestTitle: ciContext.pullRequestTitle, |
There was a problem hiding this comment.
Do we get strong typing for what this endpoint 'builds' expects?
There was a problem hiding this comment.
No :( for that we'd need to publish types from our rest API via an open API spec or something
src/handlers/testing/exec/index.ts
Outdated
| @@ -102,39 +85,104 @@ class RunManager { | |||
| } | |||
|
|
|||
| private async post<T>(path: string, body?: unknown): Promise<T> { | |||
| const resp = await fetch(`https://api.autoblocks.ai${path}`, { | |||
| const subpath = this.isCI ? '/testing/ci' : '/testing/local'; | |||
| const resp = await fetch(`https://api.autoblocks.ai${subpath}${path}`, { | |||
There was a problem hiding this comment.
Should we be storing this domain in a constant?
There was a problem hiding this comment.
Sure I'll update
ended up not using the context from
@actions/githubfor this, didn't have a lot of stuff i needed so was easier to do it manually (most of this is copied from javascript-sdk)will follow up w/ getting pull request info when it's a
pushevent via https://docs.github.com/en/rest/commits/commits?apiVersion=2022-11-28#list-pull-requests-associated-with-a-commit. currently we'll only get pull request info onpull_requesteventssee https://github.com/autoblocksai/cli/actions/runs/7978053008/job/21782347111 for the context for this branch for an example: