Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check iscompilergenerated last in canberegistered for perf reasons #1289

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

RogerKratz
Copy link
Contributor

Reimplements PR #994, please see that PR for more info what/why this fix is for.
We recently upgraded autofac and noticed that the fix was gone. This makes "test" AssemblyScanningPerformanceTests.MeasurePerformance perf better again.

@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #1289 (2924b26) into develop (3ca27f8) will increase coverage by 0.24%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1289      +/-   ##
===========================================
+ Coverage    76.34%   76.58%   +0.24%     
===========================================
  Files          185      188       +3     
  Lines         4870     5181     +311     
  Branches      1004     1061      +57     
===========================================
+ Hits          3718     3968     +250     
- Misses         679      713      +34     
- Partials       473      500      +27     
Impacted Files Coverage Δ
...nning/OpenGenericScanningRegistrationExtensions.cs 87.73% <40.00%> (-2.47%) ⬇️
src/Autofac/Core/Registration/ComponentRegistry.cs 86.36% <0.00%> (-8.09%) ⬇️
src/Autofac/Core/Registration/ModuleRegistrar.cs 95.23% <0.00%> (-4.77%) ⬇️
...stration/ComponentRegistrationLifetimeDecorator.cs 70.83% <0.00%> (-4.17%) ⬇️
...Autofac/Core/Registration/ComponentRegistration.cs 76.74% <0.00%> (-0.48%) ⬇️
src/Autofac/Core/Container.cs 68.96% <0.00%> (ø)
...ctivators/Reflection/AutowiringPropertyInjector.cs 100.00% <0.00%> (ø)
...ilder{TLimit,TActivatorData,TRegistrationStyle}.cs 76.44% <0.00%> (ø)
src/Autofac/Features/Metadata/Meta{T,TMetadata}.cs 100.00% <0.00%> (ø)
...c/Autofac/Core/Registration/ModuleRegistrarData.cs 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ca27f8...2924b26. Read the comment docs.

Copy link
Member

@tillig tillig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how this got lost in the mix, but... whoops! Thanks for the PR and the patience.

@tillig tillig merged commit a5c714b into autofac:develop Oct 8, 2021
@RogerKratz
Copy link
Contributor Author

Perfect! A new release would be highly appreciated.

@tillig
Copy link
Member

tillig commented Oct 8, 2021

6.3.0 is cut!

@alistairjevans
Copy link
Member

If that scanning method is a hot path, it may also be worth looking at reducing the LINQ usage in future, it's possible there's additional allocations happening inside the Where loop that we could avoid to save some extra CPU.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants