Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation links to common exceptions #1359

Merged
merged 8 commits into from
Dec 18, 2022

Conversation

tillig
Copy link
Member

@tillig tillig commented Dec 13, 2022

Completes a previous branch/PR to add some links to documentation to common exception messages.

Documentation for common exceptions has been added to the documentation site.

Redirects for these docs have been set up in RTD:

Screenshot of redirects in RTD

Includes splitting the message for DefaultConstructorFinder from the message for a custom constructor finder.

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 77.99% // Head: 78.02% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (0faf5c8) compared to base (890456a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1359      +/-   ##
===========================================
+ Coverage    77.99%   78.02%   +0.02%     
===========================================
  Files          195      195              
  Lines         5590     5596       +6     
  Branches      1119     1120       +1     
===========================================
+ Hits          4360     4366       +6     
  Misses         716      716              
  Partials       514      514              
Impacted Files Coverage Δ
.../Core/Activators/Reflection/ReflectionActivator.cs 89.93% <100.00%> (+0.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@alistairjevans alistairjevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📃

@tillig tillig merged commit 0c79d7b into develop Dec 18, 2022
@tillig tillig deleted the feature/exception-msg-links branch December 18, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants