Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flaky dep #1361

Merged
merged 2 commits into from
Jan 10, 2022
Merged

Remove flaky dep #1361

merged 2 commits into from
Jan 10, 2022

Conversation

eddiebergman
Copy link
Contributor

Removes the flaky dependancy as mentioned in #1357. Ran the test several times without issue.

If the issue arises again, a better solution should be found rather than just running the test several times.

@eddiebergman eddiebergman linked an issue Jan 2, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #1361 (56e8143) into development (7252be6) will increase coverage by 88.02%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           development    #1361       +/-   ##
================================================
+ Coverage             0   88.02%   +88.02%     
================================================
  Files                0      140      +140     
  Lines                0    10993    +10993     
================================================
+ Hits                 0     9677     +9677     
- Misses               0     1316     +1316     
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
autosklearn/pipeline/classification.py 86.92% <0.00%> (ø)
...osklearn/metalearning/metafeatures/metafeatures.py 94.59% <0.00%> (ø)
...ata_preprocessing/categorical_encoding/encoding.py 96.55% <0.00%> (ø)
...eature_preprocessing/liblinear_svc_preprocessor.py 98.18% <0.00%> (ø)
autosklearn/pipeline/implementations/util.py 84.37% <0.00%> (ø)
...ne/components/classification/passive_aggressive.py 96.38% <0.00%> (ø)
...osklearn/pipeline/components/classification/lda.py 94.44% <0.00%> (ø)
autosklearn/util/data.py 40.54% <0.00%> (ø)
autosklearn/ensembles/singlebest_ensemble.py 96.29% <0.00%> (ø)
... and 131 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7252be6...56e8143. Read the comment docs.

@eddiebergman eddiebergman merged commit b01c732 into development Jan 10, 2022
github-actions bot pushed a commit that referenced this pull request Jan 10, 2022
@eddiebergman eddiebergman mentioned this pull request Jan 24, 2022
eddiebergman added a commit that referenced this pull request Jan 25, 2022
* Remove flaky dep

* Remove unused pytest import
@eddiebergman eddiebergman mentioned this pull request Jan 25, 2022
@eddiebergman eddiebergman deleted the remove_flaky_dep branch February 9, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if test requirement flaky can be removed
2 participants