Initial version of incremental record commitment (take 2) #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulksnv
reviewed
Feb 28, 2023
crates/subspace-archiving/src/archiver/incremental_record_commitments.rs
Outdated
Show resolved
Hide resolved
| let bytes_before_next_record = ((self.processed_bytes / self.record_size) + 1) | ||
| * self.record_size | ||
| - self.processed_bytes; | ||
| let padding_bytes = bytes_before_next_record % self.record_size; |
There was a problem hiding this comment.
bytes_before_next_record should be < record_size, why is the % op needed?
There was a problem hiding this comment.
In your version yes, in the code that was there before no.
crates/subspace-archiving/src/archiver/incremental_record_commitments.rs
Outdated
Show resolved
Hide resolved
nazar-pc
commented
Mar 1, 2023
| let bytes_before_next_record = ((self.processed_bytes / self.record_size) + 1) | ||
| * self.record_size | ||
| - self.processed_bytes; | ||
| let padding_bytes = bytes_before_next_record % self.record_size; |
There was a problem hiding this comment.
In your version yes, in the code that was there before no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar, but not the same as #1161, please read #1161 for background.
In this iteration incremental commitment creation is simpler due to beginning of the segment never changing (see #1200). I also improved comments in the code a bit.
Resolves #1160
Code contributor checklist: