Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker): append set -o pipefail to return shell script's pipe error #5697

Closed
wants to merge 3 commits into from
Closed

fix(docker): append set -o pipefail to return shell script's pipe error #5697

wants to merge 3 commits into from

Conversation

youtalk
Copy link
Member

@youtalk youtalk commented Jan 27, 2025 •
edited
Loading

Description

In #5661, the shell scripts ware modified to return an error if any command within the script returned an error. In this PR, it was further enhanced to return an error even when commands are connected with pipes.

As a result, for example, if rosdep fails to resolve dependencies, the CI will correctly fail with an error.

How was this PR tested?

Notes for reviewers

None.

Effects on system behavior

None.

@youtalk
append pipefail
a009764 
Signed-off-by: Yutaka Kondo <[email protected]>
@youtalk youtalk requested a review from oguzkaganozt as a code owner January 27, 2025 02:49
@youtalk youtalk self-assigned this Jan 27, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 27, 2025 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@youtalk youtalk added type:containers Docker containers, containerization of components, or container orchestration. component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check labels Jan 27, 2025
@youtalk youtalk requested review from xmfcx and mitsudome-r January 27, 2025 02:49
@youtalk youtalk changed the title fix(docker): append pipefail fix(docker): append set -o pipefail to return shell script's pipe error Jan 27, 2025
@youtalk youtalk closed this Jan 27, 2025
@youtalk youtalk deleted the fix/pipefail branch January 27, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzkaganozt oguzkaganozt Awaiting requested review from oguzkaganozt oguzkaganozt is a code owner

@xmfcx xmfcx Awaiting requested review from xmfcx

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees

@youtalk youtalk

Labels
component:openadkit Issues or Features related to Open AD Kit tag:run-health-check Run health-check type:containers Docker containers, containerization of components, or container orchestration.
Projects
Open AD Kit Working Group
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@youtalk