Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

Enable way_planner to return path close to the goal #18

Conversation

luca-fancellu
Copy link
Contributor

New feature implementation

Implemented feature

Enable way_planner to return a valid path close enough to the goal if any other path to the goal is not found.

Implementation description

Add a parameter to enable way_planner to return a valid path close to the goal if there is no path found to it.
The parameter value indicates how close to the goal the solution should be.

Add a parameter to enable way_planner to return
a valid path close to the goal if there is no path
found to it.
The parameter value indicates how close to the
goal the solution should be.

Change-Id: I2cd567a99c389e592690567cadc74f199a084526
Issue-Id: SCM-1096
Signed-off-by: Luca Fancellu <[email protected]>
Co-authored-by: Senthil Ramakrishnan <[email protected]>
@JWhitleyWork JWhitleyWork requested a review from LiyouZhou October 8, 2020 18:11
Copy link

@LiyouZhou LiyouZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LiyouZhou LiyouZhou merged commit 1e01c93 into autowarefoundation:master Oct 8, 2020
@luca-fancellu luca-fancellu deleted the feature/way_planner_close_enough_path branch October 8, 2020 20:51
icolwell-as pushed a commit to astuff/autoware.ai-core_planning that referenced this pull request Oct 22, 2020
…on#18)

Add a parameter to enable way_planner to return
a valid path close to the goal if there is no path
found to it.
The parameter value indicates how close to the
goal the solution should be.

Change-Id: I2cd567a99c389e592690567cadc74f199a084526
Issue-Id: SCM-1096
Signed-off-by: Luca Fancellu <[email protected]>
Co-authored-by: Senthil Ramakrishnan <[email protected]>
Signed-off-by: Ian Colwell <[email protected]>
JWhitleyWork pushed a commit that referenced this pull request Nov 11, 2020
* pure_pursuit code cleanup

Signed-off-by: Ian Colwell <[email protected]>

Signed-off-by: Ian Colwell <[email protected]>

* Fix bad merge

Signed-off-by: Ian Colwell <[email protected]>

Signed-off-by: Ian Colwell <[email protected]>

* Add maximum attempt parameter to way_planner (#17)

Add maximum attempt parameter to the way_planner node,
enabling the node to retry the planning to the desired
way point up to a maximum value chosen by the user.
The feature can be disabled if the parameter is zero,
meaning unlimited attempt.

Change-Id: Ibfd34629fa7e2fedaf03f8294c3730eabd869e0a
Issue-Id: SCM-1096
Signed-off-by: Luca Fancellu <[email protected]>
Co-authored-by: Senthil Ramakrishnan <[email protected]>

Co-authored-by: Senthil Ramakrishnan <[email protected]>
Signed-off-by: Ian Colwell <[email protected]>

* Enable way_planner to return path close to the goal (#18)

Add a parameter to enable way_planner to return
a valid path close to the goal if there is no path
found to it.
The parameter value indicates how close to the
goal the solution should be.

Change-Id: I2cd567a99c389e592690567cadc74f199a084526
Issue-Id: SCM-1096
Signed-off-by: Luca Fancellu <[email protected]>
Co-authored-by: Senthil Ramakrishnan <[email protected]>
Signed-off-by: Ian Colwell <[email protected]>

* Code style fixes for way_planner (#19)

Add roslint support, Remove trailing spaces, format code,
add brackets to loop and if, add brackets to multiple conditions,
remove commented code, break lines above 120 characters.

Run roslint to check the code.

Change-Id: I71cb3d0adb61e0821a93a5de53aa7ef646e674a2
Issue-Id: SCM-1096
Signed-off-by: Luca Fancellu <[email protected]>
Signed-off-by: Ian Colwell <[email protected]>

* Merge branch 'jz/pure_pursuit_publish_cleanup' into 'as/master'

[#19] clean up how control cmds are published

See merge request astuff/autoware.ai/core_planning!29

Signed-off-by: Ian Colwell <[email protected]>

Signed-off-by: Ian Colwell <[email protected]>

* pure_pursuit cleanup #2, resolve upstream conflicts

Signed-off-by: Ian Colwell <[email protected]>

Co-authored-by: Joshua Whitley <[email protected]>
Co-authored-by: luca-fancellu <[email protected]>
Co-authored-by: Senthil Ramakrishnan <[email protected]>
Co-authored-by: Jilin Zhou <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants