CP-9378: add RegisterSubnetValidatorTx to etna-builder #889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
RegisterSubnetValidatorTx
to etna-builderRegisterSubnetValidatorTx
class andRegisterSubnetValidator
classRegisterSubnetValidatorTx
Issues:
RegisterSubnetValidatorTx
serialization and deserialization needs to be updated with proper message formatnot enough bytes
errorRegisterSubnetValidatorMessage
should probably be removed.Notes:
Based on what I see in avalanchego e2e flow, to issue RegisterSubnetValidatorTx, we have to go through the following flow
warpmessage.NewRegisterSubnetValidator
: creating the RegisterSubnetValidatorMessagewarp.NewUnsignedMessage
: creating the unsigned warp messagewrapWarpSignatureRequest(unsignedRegisterSubnetValidator)
: sending the request to sign the warp messagefindMessage(genesisPeerMessages, unwrapWarpSignature)
: getting the signature responsewarp.NewMessage(unsignedRegisterSubnetValidator)
: creating the signed warp message to register the validatorIssueRegisterSubnetValidatorTx
: issuing a RegisterSubnetValidatorTx