Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-9378: add RegisterSubnetValidatorTx to etna-builder #889

Closed
wants to merge 5 commits into from

Conversation

ruijialin-avalabs
Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs commented Oct 25, 2024

Description:

  • added RegisterSubnetValidatorTx to etna-builder
  • created RegisterSubnetValidatorTx class and RegisterSubnetValidator class
  • updated typeguards
  • added example to issue RegisterSubnetValidatorTx

Issues:

  • RegisterSubnetValidatorTx serialization and deserialization needs to be updated with proper message format
  • currently RegisterSubnetValidatorTx.fromBytes is paring the message incorrectly, when running the complexity test, it throw not enough bytes error
  • RegisterSubnetValidatorMessage should probably be removed.

Notes:
Based on what I see in avalanchego e2e flow, to issue RegisterSubnetValidatorTx, we have to go through the following flow

  • warpmessage.NewRegisterSubnetValidator: creating the RegisterSubnetValidatorMessage
  • registering the validator
    • warp.NewUnsignedMessage: creating the unsigned warp message
    • wrapWarpSignatureRequest(unsignedRegisterSubnetValidator): sending the request to sign the warp message
    • findMessage(genesisPeerMessages, unwrapWarpSignature): getting the signature response
    • warp.NewMessage(unsignedRegisterSubnetValidator): creating the signed warp message to register the validator
    • IssueRegisterSubnetValidatorTx: issuing a RegisterSubnetValidatorTx

@erictaylor
Copy link
Member

Closing in favor #391

@erictaylor erictaylor closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants