-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use new avalanchego utils/crypto/bls/signers/local
package
#716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpringle
requested review from
ceyonur,
darioush and
a team
as code owners
December 20, 2024 18:20
richardpringle
commented
Dec 20, 2024
qdm12
previously approved these changes
Dec 30, 2024
Tests need to be updated for imports: https://github.com/ava-labs/coreth/actions/runs/12436458610/job/34724339849?pr=716 🙏 |
darioush
reviewed
Jan 6, 2025
darioush
previously approved these changes
Jan 6, 2025
ceyonur
previously approved these changes
Jan 7, 2025
qdm12
requested changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good except let's keep the short commit hash to 12 characters as it was to avoid any surprise for now.
qdm12
reviewed
Jan 21, 2025
qdm12
previously approved these changes
Jan 21, 2025
qdm12
changed the title
Use new local-signer package
chore: use new avalanchego Jan 21, 2025
utils/crypto/bls/signers/local
package
richardpringle
force-pushed
the
encapsulate-signer
branch
from
January 28, 2025 18:20
45f72a4
to
9ccd798
Compare
darioush
approved these changes
Jan 29, 2025
ceyonur
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I've moved specific signing implementations outside of the
bls
packageHow this was tested
No functional changes, so just unit tests
Need to be documented?
Nope
Need to update RELEASES.md?
Nope