Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new avalanchego utils/crypto/bls/signers/local package #716

Merged
merged 10 commits into from
Jan 29, 2025

Conversation

richardpringle
Copy link
Contributor

Why this should be merged

I've moved specific signing implementations outside of the bls package

How this was tested

No functional changes, so just unit tests

Need to be documented?

Nope

Need to update RELEASES.md?

Nope

@richardpringle richardpringle requested review from ceyonur, darioush and a team as code owners December 20, 2024 18:20
utils/snow.go Outdated Show resolved Hide resolved
qdm12
qdm12 previously approved these changes Dec 30, 2024
@qdm12
Copy link
Collaborator

qdm12 commented Dec 30, 2024

Tests need to be updated for imports: https://github.com/ava-labs/coreth/actions/runs/12436458610/job/34724339849?pr=716 🙏

go.mod Outdated Show resolved Hide resolved
darioush
darioush previously approved these changes Jan 6, 2025
ceyonur
ceyonur previously approved these changes Jan 7, 2025
Copy link
Collaborator

@qdm12 qdm12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good except let's keep the short commit hash to 12 characters as it was to avoid any surprise for now.

scripts/versions.sh Outdated Show resolved Hide resolved
@ceyonur ceyonur dismissed stale reviews from darioush and themself via 48c1789 January 16, 2025 18:36
scripts/versions.sh Outdated Show resolved Hide resolved
qdm12
qdm12 previously approved these changes Jan 21, 2025
@qdm12 qdm12 changed the title Use new local-signer package chore: use new avalanchego utils/crypto/bls/signers/local package Jan 21, 2025
@darioush darioush merged commit 1d21850 into master Jan 29, 2025
8 checks passed
@darioush darioush deleted the encapsulate-signer branch January 29, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants