chore(ci): define github labels as code #731
Conversation
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
615a118 to
51fd319
Compare
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
188ec04 to
d949aa3
Compare
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
d949aa3 to
de8b544
Compare
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
de8b544 to
fc9d106
Compare
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
4 times, most recently
from
cfc3742 to
b95e6cf
Compare
qdm12
dismissed stale reviews from darioush and meaghanfitzgerald
via
c9572c1
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
c9572c1 to
7ecd91a
Compare
Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
Signed-off-by: Quentin McGaw <[email protected]>
qdm12
force-pushed
the
qdm12/ci/github-labels
branch
from
7ecd91a to
f72eb01
Compare
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: crazy-max/ghaction-github-labeler@v5 |
There was a problem hiding this comment.
I will play the devils advocate here. I'm not sure if using an external action justifies the advantage (at least in daily usage). Maybe I'm not seeing the exact advantage here, but it seems to me that this can just be a 5 min operation if we ever wanted to fully rename all labels (through https://github.com/ava-labs/coreth/labels). Not sure if it's worth to run a 3rd party action in every push/pull. even though the action can be something secure it still adds to the CI overhead.
There was a problem hiding this comment.
The aim is to have source-controlled, reviewable (through PRs) Github labels. The rename part is only useful once, for example to rename default label names.
The action also runs in its own workflow only when labels yml files are changed, so it won't pollute on every commit.
Why this should be merged
Allow to track in source control the Github labels, and to easily migrate Github labels (i.e. renames).
How this works
New Github workflow
.github/workflows/labels.ymlusinggithub/labels.ymlas a source for the labels. All the label data was extracted from this API call to keep it the exact same.Removed useless labels according to Darioush 😉
How this was tested
Dry run of labeler job on this PR
Need to be documented?
No
Need to update RELEASES.md?
No