chore(core/types): Header libevm Copy hook
#759
Draft
+25
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
2 times, most recently
from
88fa9e2 to
bde7fb2
Compare
2 tasks
darioush
approved these changes
Jan 21, 2025
qdm12
commented
Jan 21, 2025
| extraCopy.ExtDataGasUsed.SetBytes(h.ExtDataGasUsed.Bytes()) | ||
| } | ||
|
|
||
| cpy := ethtypes.CopyEthHeader(header) |
There was a problem hiding this comment.
I chose to export the original eth CopyHeader as CopyEthHeader, otherwise we would have to re-implement here (I tried to unexport it as copyHeader before this change).
qdm12
commented
Jan 21, 2025
qdm12
changed the title
Header libevm Copy hook
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
from
495e9b6 to
da83d82
Compare
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
from
da83d82 to
58f1171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
➡️ header copy hooks libevm PR
How this was tested
Need to be documented?
Need to update RELEASES.md?