Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t.deepEqual seems to ignore symbol key properties #1121

Closed
mightyiam opened this issue Nov 20, 2016 · 7 comments
Closed

t.deepEqual seems to ignore symbol key properties #1121

mightyiam opened this issue Nov 20, 2016 · 7 comments

Comments

@mightyiam
Copy link
Contributor

Description

t.deepEqual is affected by upstream lodash issue. It means that

t.deepEqual({[Symbol()]: undefined}, {})
// true

Relevant Links

@mightyiam
Copy link
Contributor Author

Upstream was fixed in less than two hours after reported 🎉
I wonder whether I should even ask for a release.

@vadimdemedes
Copy link
Contributor

Since the lodash.isEqual is fixed now, we just need to update the dependency. Thanks for reporting!

@jdalton
Copy link
Contributor

jdalton commented Nov 26, 2016

I haven't cut a release yet.

@vadimdemedes
Copy link
Contributor

@jdalton Thanks for the note! We'll keep watching and update when it's ready.

@mightyiam
Copy link
Contributor Author

@jdalton please 😸

@mightyiam
Copy link
Contributor Author

There has been a release of v4.17.4 but not of lodash.isequal, which is what we use. @jdalton, will you please publish that?

@jdalton
Copy link
Contributor

jdalton commented Jan 9, 2017

Ah yep, will do. Look for it some time on the 9th.

Updated lodash.isequal to v4.5.0.

sindresorhus pushed a commit that referenced this issue Jan 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants