Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Babel presets #1197

Merged
merged 4 commits into from
Jan 20, 2017
Merged

Extract Babel presets #1197

merged 4 commits into from
Jan 20, 2017

Conversation

novemberborn
Copy link
Member

Removes deprecated assertions (breaking!)

Uses the new Babel presets (#1193, #1195). Will publish those dependencies and update the package.json references when CI passes.

Since this removes babel-runtime we can close #947 and #1089.

};
}

const defaultPresets = lazy(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@novemberborn Do you remember why we have laziness here? There must be a reason. Maybe we should preserve the laziness?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seemed unnecessary yesterday but I think I figured it out. This config is used even if all transforms have been cached. So we should keep the laziness in place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Restored the lazy behavior, though in a somewhat simplified form.

@tylerjharden
Copy link

So this is good to go? And fixes "warning ava > [email protected]: Use npmjs.org/babel-preset-env instead, see https://github.com/babel/babel-preset-env"?

Very exciting if so.

@novemberborn novemberborn force-pushed the extract-babel-presets branch from c9860e0 to 9834ffe Compare January 19, 2017 16:55
@sindresorhus
Copy link
Member

@novemberborn I tried this PR on some of my projects, like Got, Pageres, etc, and seems to be working well.

@sindresorhus
Copy link
Member

@tylerjharden Yes, it removes the warning. It's good to go when it's done.

@novemberborn
Copy link
Member Author

It's good to go when it's done.

@sindresorhus Could you approve it then? ;-) CI failure is just AppVeyor being confused.

@sindresorhus
Copy link
Member

@novemberborn Don't you need to publish the extracted modules first and update package.json? Right now they reference Git commits.

@novemberborn
Copy link
Member Author

Don't you need to publish the extracted modules first and update package.json? Right now they reference Git commits.

Hence the DO NOT MERGE label 😉

@sindresorhus
Copy link
Member

It's approved. :shipit: :shipit: :shipit: :shipit:

Fixes #1193, #1195.

Closes #947 and #1089, since babel-runtime is removed.
@sindresorhus
Copy link
Member

1ab7e29c-117e-11e6-9cbb-f0828bacea8e

@mightyiam
Copy link
Contributor

Can't wait for next release.

@danez
Copy link
Contributor

danez commented Mar 24, 2017

This PR removed the stage-2 preset and broke my test when updating as I was using object-spread. Should I change the README and remove the mention of stage-2 or was that removed by mistake?

@novemberborn
Copy link
Member Author

@danez yes, this sentence shouldn't mention stage-2:

We use our own bundled Babel with our @ava/stage-4 and stage-2 preset, as well as custom transforms for test and helper files.

We would appreciate a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable babel-plugin-transform-runtime?
5 participants