-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Babel presets #1197
Extract Babel presets #1197
Conversation
}; | ||
} | ||
|
||
const defaultPresets = lazy(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@novemberborn Do you remember why we have laziness here? There must be a reason. Maybe we should preserve the laziness?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed unnecessary yesterday but I think I figured it out. This config is used even if all transforms have been cached. So we should keep the laziness in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restored the lazy behavior, though in a somewhat simplified form.
4b88d51
to
86a7513
Compare
c96c38a
to
c9860e0
Compare
So this is good to go? And fixes "warning ava > [email protected]: Use npmjs.org/babel-preset-env instead, see https://github.com/babel/babel-preset-env"? Very exciting if so. |
c9860e0
to
9834ffe
Compare
@novemberborn I tried this PR on some of my projects, like Got, Pageres, etc, and seems to be working well. |
@tylerjharden Yes, it removes the warning. It's good to go when it's done. |
@sindresorhus Could you approve it then? ;-) CI failure is just AppVeyor being confused. |
@novemberborn Don't you need to publish the extracted modules first and update package.json? Right now they reference Git commits. |
Hence the |
It's approved. |
9834ffe
to
1542ccd
Compare
Can't wait for next release. |
This PR removed the stage-2 preset and broke my test when updating as I was using object-spread. Should I change the README and remove the mention of stage-2 or was that removed by mistake? |
@danez yes, this sentence shouldn't mention
We would appreciate a PR! |
Removes deprecated assertions (breaking!)
Uses the new Babel presets (#1193, #1195). Will publish those dependencies and update the
package.json
references when CI passes.Since this removes
babel-runtime
we can close #947 and #1089.