fix context for beforeEach and afterEach hooks in Flow type definition file #1344
Conversation
|
@gajus does this work for you? |
|
This works. 👍 |
|
I have no idea why it failed for node 4... |
| @@ -25,11 +25,6 @@ test.cb(t => { | |||
| t.end(); | |||
| }); | |||
|
|
|||
| test.beforeEach(t => { | |||
| // $ExpectError: Unknown property "context" | |||
There was a problem hiding this comment.
Perhaps keep the beforeEach, but remove this $ExpectedError line.
There was a problem hiding this comment.
I thought about keeping the beforeEach, but then I thought it has nothing to with the issue #1114. But maybe it has, I didn't dig deeper.
There was a problem hiding this comment.
BTW, how to trigger a rebuild? I didn't find that, never used Appveyor before.
There was a problem hiding this comment.
It's used elsewhere in this file, so might be best to keep it.
I think you have to be in the AppVeyor team to do that.
There was a problem hiding this comment.
You can also push an empty commit or force push, to trigger a rebuild.
|
I think this is good now. I suppose the changes may break something because some types have been removed? But even if so it seems like a good bugfix that we should just ship in a |
|
Hm I don't know. I only removed "dead" types, so I hope it won't break anything. |
|
Whats the shipping plan? |
This reverts commit a1a8195.
Fixes #1340