Remove runtime from lib/babel #150
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It brings polyfills and breaks tests for old Node.js
Closed
|
Couldn't it just read the runtime from https://github.com/facebook/regenerator ? |
| @@ -1,5 +1,6 @@ | |||
| 'use strict'; | |||
| const test = require('../../'); | |||
| const Promise = require('bluebird'); | |||
There was a problem hiding this comment.
Why? I don't want to manually require a Promise polyfill in all my tests.
There was a problem hiding this comment.
Yes, it is lame to include polyfills in test files - but it is bad to include global polyfills either (because they leak to production code).
There was a problem hiding this comment.
I guess there's really no good solution for this...
This is what |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #144
runtimewith polyfillsregeneratorto test files