Do not clobber forked process color level. #1713
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chalk uses `supports-color` to determine what color level should be rendered. However, currently our parent `ava` process uses that to colorize its output, however, when we fork our test processes we clobber the color configuration that `supports-color` uses to determine the level (see https://github.com/chalk/supports-color/blob/master/index.js#L37-L42) This PR carries the current color level through to the forked processes so if they log output that is colorized it will remain so with the same fidelity of colors as the parent ava process.
|
Thanks @jamiebuilds. What do you think about bundling |
|
We should make some more changes, see #1701 (comment). I still need to land #1722 though. |
|
Closing due to inactivity. There's been changes in how AVA uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked changes from #1455 to resolve #1701
Chalk uses
supports-colorto determine what color level should berendered. However, currently our parent
avaprocess uses that tocolorize its output, however, when we fork our test processes we clobber
the color configuration that
supports-coloruses to determine thelevel (see https://github.com/chalk/supports-color/blob/master/index.js#L37-L42)
This PR carries the current color level through to the forked processes
so if they log output that is colorized it will remain so with the same
fidelity of colors as the parent ava process.