Ignore files in fixtures and helpers directories #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,7 +119,7 @@ $ ava --help | |||
| test.js test-*.js test/*.js | |||
| ``` | |||
|
|
|||
| Files starting with `_` are ignored. This can be useful for having helpers in the same directory as your test files. | |||
| Files in directories named `fixtures` and `helpers` are ignored. This can be useful for having helpers in the same directory as your test files. | |||
There was a problem hiding this comment.
Don't remove this part starting with _. We still support that.
|
Could you squash commits into one? |
| @@ -0,0 +1,6 @@ | |||
| import test from '../../'; | |||
There was a problem hiding this comment.
I think the fixtures should be placed in a super folder with a descriptive name. Like test/fixture/ignored-dirs/fixtures/test.js. Right now it looks like it's for something else. Same with the below.
There was a problem hiding this comment.
Great point—agreed. I'll do this after my flight. @sindresorhus after I make that change should I squash that commit with the rest?
Don't ignore files starting with '_' Ignore files starting with '_' Fix path for fixtures Add 'fixtures' path to tests Move ignored fixtures to their own directory
sindresorhus
added a commit
that referenced
this pull request
Dec 24, 2015
Ignore files in fixtures and helpers directories
|
Looks good! Thank you @sotojuan. Merry xmas! 🎅 🎄 |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #355 by adding the required code to ignore files in directories named
fixturesand/orhelpersas well as documentation and tests.