Skip to content
This repository has been archived by the owner on Mar 9, 2020. It is now read-only.

Implement preset #1

Merged
merged 3 commits into from
Jan 20, 2017
Merged

Implement preset #1

merged 3 commits into from
Jan 20, 2017

Conversation

novemberborn
Copy link
Member

@novemberborn
Copy link
Member Author

This removes the deprecated APIs: https://github.com/avajs/ava/blob/a380fe4f5ffa1d334a2a3786215d3c1ff10a9898/lib/enhance-assert.js#L17:L21

@novemberborn
Copy link
Member Author

Forgot that we needed a way to disable power-assert…

sindresorhus
sindresorhus reviewed Jan 18, 2017
View reviewed changes
index.js

function buildPreset(context, options) {
const plugins = [];
if (!options || options.powerAssert !== false) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The option should be documented in the readme.

sindresorhus
sindresorhus reviewed Jan 18, 2017
View reviewed changes
index.js
@@ -0,0 +1,15 @@
const ESPOWER_PATTERNS = require('./espower-patterns.json');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add 'use strict'; above here.

@novemberborn novemberborn force-pushed the makeitso branch 2 times, most recently from 15c0ad5 to 75f5543 Compare January 19, 2017 13:02
@novemberborn novemberborn merged commit 8563085 into master Jan 20, 2017
@novemberborn novemberborn deleted the makeitso branch January 20, 2017 09:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sindresorhus sindresorhus sindresorhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@novemberborn @sindresorhus