-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Deleted items in playlist break IIIF manifest generation #5395
Comments
working in IIIF; Ramp is displaying a different error message than we would expect to see. Re-test this in Ramp after Ramp samvera-labs/ramp#263 is merged. |
@charumitraravi I see that #263 is not merged yet, so we'll actually need to wait on QA for this. |
@charumitraravi #263 is now merged, this should be ready for QA |
@elynema Note:This happens only when the deleted item is the last item in the playlist. |
@charumitraravi Can you create a new bug in the Ramp repository for this? The manifest looks ok, so this is an issue with how the deleted item is being loaded into the Ramp, in particularly the markers, when it's hit with autoplay. |
Actual Behavior
When the underlying item of a playlist item gets deleted it breaks IIIF manifest generation.
Expected Behavior
Playlist items with deleted source content should appear in IIIF manifest with a displayable note for the user.
Steps to reproduce
Go to https://avalon-dev.dlib.indiana.edu/playlists/32/manifest.json
This is the error I'm seeing in the browser. My guess is that using the safe navigator could possibly resolve the error.
Done Looks Like
The text was updated successfully, but these errors were encountered: