-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render placeholderCanvas Element for Empty Canvases #263
Comments
Ramp is rendering the placeholderCanvas properly when a new item has been uploaded to a media object and is not available and when there is a restricted/deleted item in a playlist. I'm not entirely sure how to test the general case where a canvas has no items and also does not have a placeholderCanvas. @Dananji is there a way to test this general case relatively easily? Or have you already tested that? |
Created a manifest for a playlist with only 1 item and that item is restricted and removed the placeholderCanvas: https://raw.githubusercontent.com/elynema/sample-manifests/main/manifest-playlist-empty-canvas.json. I confirmed that in this scenario, the Ramp demo site says "This item cannot be played." The IIIF Presentation validator does not like this test manifest at all for several reasons (the fact that there is only 1 empty canvas could be part of it?): URL Tested: https://raw.githubusercontent.com/elynema/sample-manifests/main/manifest-playlist-empty-canvas.json Error 1 of 3. Message: 'items' is a required property Resolving that is probably a separate issue. |
Corresponds to the work to represent empty media objects or sections so that they render with a message to the user about the fact that the item/media is missing or deleted.
Ramp should render the placeholderCanvas for any canvas that does not have items (or has empty items?)
Done Looks Like
The text was updated successfully, but these errors were encountered: