-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way to assign a date to each release #11
Comments
Yep, I think this could be a good addition. I just wonder how much of this On Mon, Apr 22, 2013 at 6:44 PM, Dennis Daume [email protected]:
|
Since it's quite common (well, at least I think it is) to write the date of the release beside the version, I'd say this should be supported directly by the spec, so that nobody has to bake their own solution every time. But it should also definitely be optional. This could also fit with @shiftkey 's idea in #2 to use the file's name as version, for example:
and when not using the date, just
|
I'm skeptical on the need for this because other systems will take care of tracking this release date for me. For example:
As a consumer or publisher of software, the date of a release isn't something I really care about (i'm excluding blog posts from this discussion). Some scenarios:
@flagbug can you share some scenarios about how controlling this date (rather than leaving it up to external factors) is of benefit to you? |
I'm also on the fence whether this is needed or not, but I think we get something very close as a happenstance if we take on @shiftkey's suggestion in #2. If we do take on #2, and we support/recognize file names that follow Semantic Versioning (semver), than we should make pre-release version and the build version available in the returned structured output. Here's some examples:
Many .NET developers don't realize that the semver specification provides for adding a build token after the Developers already use the build token to place the date of a given build (so this usage isn't out of line) or the hash of last commit. Of course, given that the build token can be any character in the set At the same time, I also argue that a build label isn't relevant for end users/release notes, but if we are going to support semver in the file name, we should support the whole spec. |
One last comment, but it isn't one I'm particularly concerned about: Supporting all of semver in a file name means that a user can and will place a Like I said, I don't really care about this limitation, but wanted to point it out. |
@nikmd23 I think this is an excellent idea! |
@shiftkey I have no clue who to complain to about SharePoint, but I know that limitation had been around for at least the last three major versions - so I'm not sure that it would be changeable anyways. |
@nikmd23 we don't actually care about the Sharepoint filesystem, right? |
I do not, and I think that the collective we do not either. However, you asked:
So I provided the serious answer. 😜 |
My only slight concern with the build number idea is that to include a date we are saying that:
|
@avanderhoorn Isn't the idea that you can write anything in the range of |
Agreed. My concern was around if someone isn't using date as their build On Wednesday, April 24, 2013, Dennis Daume wrote:
|
I would like this too, in the case of multiple releases in a singe document. The releases stuff would be good to get specd out. I think possibly releases should be in the format
The date in brackets would be optional |
On a slight tangent. How does this differentiate between a release with sections, or multiple releases in a single document? |
+1 having the ability and strong recommendation to include date. My reasoning is for sanity checks. If I go to a release page, it should be obvious by inspection how new it is (-not- in the horrid offset format date) and also how far apart the releases are spaced. It also helps me error-check my download/install. |
I think that a release in a multiple release document could be recognize by this format: The 'v', date and summary are optionals and the version (0.0.0) must respect the SemVer format. Are you ok with that? |
Are you thinking that this would be part of the file name or the header within the release note? |
The header within the release note. |
Makes sense to me - anyone got any other objections/thoughts? Only thing to be worked out is what a header for the release would look like. Currently the |
I think |
Does anyone else have any thoughts on these before moving ahead? |
Sounds great to me. I like date in ISO format, eg 2015-01-31, and due to a situation I had a few days ago I'm wondering if datestamp would also be reasonable to include? Or maybe is the timestamp already available elsewhere and it can be posted in the description? |
I like year month day as well. Seems to avoid any possible confusion no matter were you are from. |
For release notes I think 'dd mmm yy' works well. Eg '26 Feb 15' which is also universal. Sent from my Windows Phone From: Anthony van der Hoornmailto:[email protected] I like year month day as well. Seems to avoid any possible confusion no matter were you are from. — |
Makes sense. |
To me the cool thing about year-month-day is its being inherently directly sortable, no conversion needed, plus of course no European/American mixups are possible. |
I think the 'dd mmm yy' format could bring some problem, unless we suppose the language used is english. |
+1 I think the output format can be what ever the author of the formatter wants it to be be, but the SRN format should be more controlled and standardised - hence I'm leaning toward yyyy-mm-dd. |
Sounds fair and supports non-english release notes. Sent from my Windows Phone From: Anthony van der Hoornmailto:[email protected] +1 I think the output format can be what ever the author of the formatter wants it to be be, but the SRN format should be more controlled and standardised - hence I'm leaning toward yyyy-mm-dd. — |
Ok, now that we have come with the date format we need to settle on what determines the Header for the release notes, if that header facilitates multiple releases in the same blob of text/document, etc. Denoting the release/document title
Multiple releases per document/text blob
Exact format for the title Given that, here are some early thoughts:
I'm thinking that for sanity's sake if we needed to show more than Title, Version and Release Date, this would need to shift to keyed metadata - as discussed here #14. Additionally, I'm already wondering if a simple enough parser can be created for parsing the above use cases. What do you think, are there many more use cases, etc? For all the above, does this feel right to others, keep moving forward with these change? |
Finally I have a chance to open my laptop and read this stuff properly. One problem I have is that markdown is itself a format which can be rendered directly. I think that any sort of header should be a version title, this allows the use of As for the title itself I think those cases are good but we need to think about error cases:
What other cases would blow up? |
" Multiple releases per document/text blob" |
@JakeGinnivan It's a good idea to have a different syntax to distinguish a release title from a section. |
I am saying all headers are considered release titles. Maybe except h4. That is not multiple ways, but it allows flexibility. Why have the format in markdown if it will never be rendered? :) Sent from my Windows Phone From: Jérémie Bertrandmailto:[email protected] @JakeGinnivanhttps://github.com/JakeGinnivan It's a good idea to have a different syntax to distinguish a release title from a section. — |
I like having a single releasenotes.md in my GitHub repo. Sent from my Windows Phone From: AnneTheAgilemailto:[email protected] Multiple releases per document/text blob — |
All right, you mark a point :) |
@AnneTheAgile That was the idea. Like @JakeGinnivan said, many people like having a single document with a running list of release notes. Hence making sure the format supports having n number of releases in one "doc" seems to make sense. I like the idea of switching it over to |
Maybe one a title is matched any lesser header is a section? As an example:
Also valid
Also
Also
This could be more complex but makes for nice reading in raw format or rendered markdown. All are semantically the same (lesser header is a section) Sent from my Windows Phone From: Anthony van der Hoornmailto:[email protected] @AnneTheAgilehttps://github.com/AnneTheAgile That was the idea. Like @JakeGinnivanhttps://github.com/JakeGinnivan said, many people like having a single document with a running list of release notes. Hence making sure the format supports having n number of releases in one "doc" seems to make sense. I like the idea of switching it over to section that's on its own line. Part of me thinks that when you are reading a document, it doesn't stand out as much as a sub section title, but this could just be me. — |
My only concern is if someone uses the headings with the intent of them to be ### title and #### section, and then has other # xyz and ## abc's in the document, how would that work? If headings are present in the document, would we always interpret the first 2 headings as Title and Section, regardless of if they are # & ## or ### & ####? Seems a bit loose, but I can see why. |
I think we should enforce that they are all the same. So if you use #, ## and ### in the same document it will fail. It is loose but still semantically the same. |
Just reviving this discussion. Thoughts on the above point? I still think that being a markdown format, it should be able to be rendered as is and not have to transform markdown -> markdown to be formatted nicely. |
I'm ok with the flexibility, like you said it is a markdown format and should be able to rendered as is. So to resume:
Is that ok? |
Yep, that works for me. @avanderhoorn? |
Just thought of an issue with my suggestion, how would we be able to distinguish between a document with multiple releases and no sections vs a document with just multiple sections? |
I think going back to this is a better idea. Section headers are simply a bold line, and |
Just and update so you know that I'm not ignoring you guys, I've just had a baby and on leave at the moment. Back on deck next week. |
@avanderhoorn Congrats! 😃 @JakeGinnivan Nice catch I haven't see that. I'm ok with the bold line for a section, just to clarify are we supporting the two markdown notations ( |
@avanderhoorn Congrats! All good enjoy your leave. @laedit yeah we should support both |
Allowing multiple header sizes though would mean that metadata would need to be held in the json representation to allow round-trips.
Turns into
|
So what would multiple releases look like?
Also are we agreeing to fail a document that has the presence of multiple heading types or would we say that what ever the lowest heading type that is present is the release one? |
Unsure what you mean by I am leaning towards only one size of headers present in the document |
I was thinking something like:
In this case it would see that multiple heading levels are used and ignore the "#" in favour for the lowest heading level (in this case "##"). I personally don't like this... I don't think its 100% clear. |
Ah I get you.. Hrrm. For my scenarios I can't see the need for having a document title inside the release notes. If you publish via jekyll or something the title will come from yaml front-matter and for ReleaseNotes.md the title is inferred from the filename. I vote for a single header size within a document. |
Good for me too, otherwise it's too confusing. |
Great! |
As the title says, I think there should be a way to tag a release with an (optional) release-date.
The text was updated successfully, but these errors were encountered: