Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] sale_crm_school: Coger ordenante del producto no del la categoría #47

Merged
merged 1 commit into from
Jul 24, 2019
Merged

[IMP] sale_crm_school: Coger ordenante del producto no del la categoría #47

merged 1 commit into from
Jul 24, 2019

Conversation

alfredoavanzosc
Copy link
Contributor

…ria.

@codecov
Copy link

codecov bot commented Jul 17, 2019 •
edited
Loading

Codecov Report

Merging #47 into 12.0 will increase coverage by 0.64%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             12.0      #47      +/-   ##
==========================================
+ Coverage   96.96%   97.61%   +0.64%     
==========================================
  Files          14       13       -1     
  Lines         165      168       +3     
==========================================
+ Hits          160      164       +4     
+ Misses          5        4       -1
Impacted Files Coverage Δ
sale_crm_school/models/product.py 100% <ø> (ø) ⬆️
sale_crm_school/models/sale_order.py 100% <100%> (ø) ⬆️
sale_crm_school/models/crm_lead.py 100% <100%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edecec2...b65d52b. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 17, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.6%) to 97.619% when pulling b65d52b on alfredoavanzosc:sale-addons12-sale_crm_school into edecec2 on avanzosc:12.0.

@alfredoavanzosc
Copy link
Contributor Author

@avanzosc/developers ... review please.

@oihane
Copy link
Contributor

oihane commented Jul 18, 2019

@anajuaristi si no se va a utilizar el originator_id de la categoria convendría eliminarlo

@alfredoavanzosc alfredoavanzosc force-pushed the sale-addons12-sale_crm_school branch from 161c54b to 24e692a Compare July 22, 2019 07:35
@alfredoavanzosc
Copy link
Contributor Author

alfredoavanzosc commented Jul 22, 2019 •
edited
Loading

He quitado el campo "originator_id" de plantillas de producto, como me solicitó @oihane , y después de comentarlo con @anajuaristi . He vuelto a subir el módulo. Eskerrik asko.
Además he hecho lo siguiente que me ha solicitado @anajuaristi:

1.- En cabecera de la plantilla, many2one a colegio --> mostrar en tree y form e incluir en búsqueda y agrupación.
2.- En líneas de la plantilla, mostrar de modo Related al producto la Compañía asociada.
3.- Actualmente, al crear presupuesto desde CRM, lo que hace es enlazar la plantilla asociada al curso en el que se va a matricular el niño. Debe coger, además del curso, el cole a la hora de seleccionar la plantilla.

Daniel-CA
Daniel-CA previously requested changes Jul 23, 2019
View reviewed changes
Copy link
Collaborator

@Daniel-CA Daniel-CA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Según entiendo el center_id también hay que quitarlo de la categoría de producto.

@alfredoavanzosc
Copy link
Contributor Author

@anajuaristi ¿Debo de hace lo que me dice @Daniel-CA?

@alfredoavanzosc alfredoavanzosc force-pushed the sale-addons12-sale_crm_school branch from 24e692a to f79891d Compare July 24, 2019 07:12
@oihane oihane changed the title [IMP] sale_crm_school: Coger oranizador del producto no del la catego… [IMP] sale_crm_school: Coger ordenante del producto no del la categoría Jul 24, 2019
@alfredoavanzosc alfredoavanzosc dismissed Daniel-CA’s stale review July 24, 2019 07:23

Dani... ya he quitado el centro de la categoría de producto como hablamos ayer. Eskerrik asko.

@anajuaristi
Copy link
Contributor

@avanzosc/developers please review

@oihane oihane requested a review from Daniel-CA July 24, 2019 11:41
oihane
oihane reviewed Jul 24, 2019
View reviewed changes
sale_crm_school/models/product.py Outdated
@@ -8,5 +8,4 @@ class ProductTemplate(models.Model):
_inherit = 'product.template'

center_id = fields.Many2one(
relation='res.partner', string='Center', readonly=True,
related='categ_id.center_id', store=True)
comodel_name='res.partner', string='Center')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deberia de ser colegio no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Falta el domain

domain=[('educational_category', '=', 'school')]

oihane
oihane previously requested changes Jul 24, 2019
View reviewed changes
Copy link
Contributor

@oihane oihane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comentario a revisar.

@alfredoavanzosc alfredoavanzosc force-pushed the sale-addons12-sale_crm_school branch from f79891d to 14c0f0e Compare July 24, 2019 14:01
@alfredoavanzosc alfredoavanzosc force-pushed the sale-addons12-sale_crm_school branch from 14c0f0e to b65d52b Compare July 24, 2019 14:05
@alfredoavanzosc alfredoavanzosc dismissed oihane’s stale review July 24, 2019 14:06

Realizada la corrección solicitada por @oihane. Eskerrik asko.

@alfredoavanzosc alfredoavanzosc merged commit 8cfaa23 into avanzosc:12.0 Jul 24, 2019
@alfredoavanzosc alfredoavanzosc deleted the sale-addons12-sale_crm_school branch July 24, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oihane oihane oihane left review comments

@anajuaristi anajuaristi anajuaristi approved these changes

@Daniel-CA Daniel-CA Daniel-CA approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alfredoavanzosc @coveralls @oihane @anajuaristi @Daniel-CA