Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] sale_order_rental: This module put the start date, end date and… #50

Merged
merged 3 commits into from
Nov 20, 2019
Merged

[ADD] sale_order_rental: This module put the start date, end date and… #50

merged 3 commits into from
Nov 20, 2019

Conversation

OihanaLarranaga
Copy link

No description provided.

@coveralls
Copy link

coveralls commented Jul 30, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-1.9%) to 98.148% when pulling 3c6496b on OihanaLarranaga:sale-addons12-sale_order_rental into 24dc9e8 on avanzosc:12.0.

@OihanaLarranaga OihanaLarranaga force-pushed the sale-addons12-sale_order_rental branch from eac6c1a to 7b3e865 Compare July 30, 2019 07:31
@codecov
Copy link

codecov bot commented Jul 30, 2019

Codecov Report

Merging #50 into 12.0 will decrease coverage by 20.94%.
The diff coverage is 52.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##             12.0      #50       +/-   ##
===========================================
- Coverage   97.61%   76.67%   -20.95%     
===========================================
  Files          13       17        +4     
  Lines         168      313      +145     
===========================================
+ Hits          164      240       +76     
- Misses          4       73       +69
Impacted Files Coverage Δ
sale_order_rental/models/stock.py 100% <100%> (ø)
sale_order_rental/models/sale_order.py 45.45% <45.45%> (ø)
sale_order_rental/models/account_invoice.py 52% <52%> (ø)
sale_order_rental/wizards/stock_picking_return.py 57.14% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cfaa23...7b3e865. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 30, 2019 •
edited
Loading

Codecov Report

Merging #50 into 12.0 will decrease coverage by 1.85%.
The diff coverage is 95.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           12.0      #50      +/-   ##
========================================
- Coverage   100%   98.14%   -1.86%     
========================================
  Files        20       27       +7     
  Lines       254      432     +178     
========================================
+ Hits        254      424     +170     
- Misses        0        8       +8
Impacted Files Coverage Δ
sale_order_rental/wizards/stock_picking_return.py 100% <100%> (ø)
sale_order_rental/models/sale_order.py 100% <100%> (ø)
sale_order_rental/models/sale_order_line.py 100% <100%> (ø)
sale_order_rental/models/stock_move.py 100% <100%> (ø)
sale_order_rental/models/account_invoice_line.py 90.32% <90.32%> (ø)
sale_order_rental/models/account_invoice.py 91.66% <91.66%> (ø)
sale_order_rental/models/stock_picking.py 93.93% <93.93%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24dc9e8...3c6496b. Read the comment docs.

@OihanaLarranaga OihanaLarranaga force-pushed the sale-addons12-sale_order_rental branch from 7b3e865 to 2fcaf6d Compare July 30, 2019 07:51
@OihanaLarranaga
Copy link
Author

@oihane no entiendo los errores que me da travis

@OihanaLarranaga OihanaLarranaga force-pushed the sale-addons12-sale_order_rental branch 4 times, most recently from e73de06 to 5150ec5 Compare August 5, 2019 14:10
@OihanaLarranaga OihanaLarranaga force-pushed the sale-addons12-sale_order_rental branch 2 times, most recently from ebe63f1 to bf23a7e Compare August 8, 2019 09:35
@OihanaLarranaga
Copy link
Author

@avanzosc/developers review please

oihane
oihane requested changes Aug 8, 2019
View reviewed changes
sale_order_rental/tests/test_sale_order_rental.py Outdated
self.sale_order.onchange_expected_end_date()
self.sale_order.onchange_expected_delivery_date()
invoice_line = self.sale_order.invoice_ids[0].invoice_line_ids[0]
invoice_line._compute_expected_delivery_date()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No debes "ejecutar" el compute si no leer el campo y validar que el valor es correcto, de esa manera ejecutará el metodo, lo mismo con el resto de líneas.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tema realizado @oihane , eskerrik asko.

sale_order_rental/tests/test_sale_order_rental.py Outdated
self.sale_order.write(
{'expected_delivery_date': False,
'expected_end_date': False})
self.sale_order.onchange_expected_end_date()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SI ejecutas un onchange tendrás que validar que lo que hace es correcto, no simplemente ejecutarlo, lo mismo con la siguiente línea.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tema realizado @oihane , necesito que me desbloquees el PR. Eskerrik asko.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tema realizado @oihane , necesito que me desbloquees el PR. Eskerrik asko.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si lo que haces es eliminar los campos en el pedido, y eso tiene que hacer que los campos en las líneas sean vacíos no es lo que estas validando. No es correcto

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realizados los cambios solicitados por @oihane

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pero cambia el campo en la línea de pedido, no estas comprobando las lineas de pedido, si no las facturas.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Realizados los cambios solicitados por @oihane

sale_order_rental/tests/test_sale_order_rental.py Outdated Show resolved Hide resolved
@alfredoavanzosc alfredoavanzosc mentioned this pull request Aug 16, 2019
Open
@OihanaLarranaga OihanaLarranaga force-pushed the sale-addons12-sale_order_rental branch 3 times, most recently from 36f0651 to 9c1413b Compare August 27, 2019 09:10
@OihanaLarranaga OihanaLarranaga force-pushed the sale-addons12-sale_order_rental branch 2 times, most recently from 54033f2 to 0373769 Compare September 5, 2019 13:31
@OihanaLarranaga
Copy link
Author

Realizadas las mejoras solicitadas por @oihane

alfredoavanzosc
alfredoavanzosc approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@alfredoavanzosc alfredoavanzosc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@OihanaLarranaga OihanaLarranaga force-pushed the sale-addons12-sale_order_rental branch from 50206e6 to 3b8eb78 Compare September 12, 2019 09:31
oihane
oihane reviewed Sep 12, 2019
View reviewed changes
sale_order_rental/tests/test_sale_order_rental.py Outdated
self.sale_order.onchange_expected_end_date()
self.sale_order.onchange_expected_delivery_date()
invoice_line = self.sale_order.invoice_ids[0].invoice_line_ids[0]
for invoice_line in self.sale_order.invoice_ids:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

si buscas facturas (invoice) no pongas invoice_line lleva a error

@OihanaLarranaga OihanaLarranaga force-pushed the sale-addons12-sale_order_rental branch from 3b8eb78 to 8484ade Compare September 13, 2019 08:50
@oihane oihane force-pushed the sale-addons12-sale_order_rental branch 3 times, most recently from 0589b03 to bfdc6dd Compare October 10, 2019 07:26
@oihane oihane force-pushed the sale-addons12-sale_order_rental branch from bfdc6dd to f074896 Compare October 21, 2019 11:06
@oihane oihane force-pushed the sale-addons12-sale_order_rental branch from 02ee55d to 55dba3e Compare November 18, 2019 10:53
@oihane oihane force-pushed the sale-addons12-sale_order_rental branch 7 times, most recently from 95113a8 to 98df64e Compare November 20, 2019 11:37
@oihane oihane force-pushed the sale-addons12-sale_order_rental branch from 98df64e to 3c6496b Compare November 20, 2019 15:23
@oihane oihane merged commit 770047f into avanzosc:12.0 Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfredoavanzosc alfredoavanzosc alfredoavanzosc approved these changes

@oihane oihane oihane approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@OihanaLarranaga @coveralls @oihane @alfredoavanzosc