Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lz signature zeroed check #719

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Lz signature zeroed check #719

merged 3 commits into from
Mar 6, 2020

Conversation

ladislav-zezula
Copy link
Contributor

No description provided.

@ladislav-zezula ladislav-zezula requested a review from s3rvac March 6, 2020 09:58
@s3rvac
Copy link
Member

s3rvac commented Mar 6, 2020

Let's run TeamCity builds to see whether everything succeeds in there.

s3rvac
s3rvac reviewed Mar 6, 2020
View reviewed changes
Copy link
Member

@s3rvac s3rvac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the added checks 👍 I have added two remarks towards the code. Apart from them, the checks are OK.

src/pelib/PeLibAux.cpp Outdated Show resolved Hide resolved
src/pelib/PeLibAux.cpp Outdated Show resolved Hide resolved
@s3rvac s3rvac merged commit f012259 into master Mar 6, 2020
@s3rvac s3rvac mentioned this pull request Mar 6, 2020
Merged
@s3rvac s3rvac deleted the LZ_SignatureZeroedCheck branch March 6, 2020 12:16
s3rvac added a commit that referenced this pull request Mar 6, 2020
@s3rvac
Add a CHANGELOG entry for #719.
ab55f8e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rvac s3rvac s3rvac left review comments

Assignees

@s3rvac s3rvac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislav-zezula @s3rvac