Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redundant setCurrentTool function call #34

Closed
robustify opened this issue Oct 16, 2017 · 0 comments
Closed

Redundant setCurrentTool function call #34

robustify opened this issue Oct 16, 2017 · 0 comments

Comments

@robustify
Copy link
Contributor

On line 208 of the current master version of flatland_viz.cpp:
https://github.com/avidbots/flatland/blob/d4e975cfee0172c967f792715f310482c050f380/flatland_viz/src/flatland_viz.cpp

there is a redundant setCurrentTool call:
manager_->getToolManager()->setCurrentTool(tool);

This should be removed.
josephduchesne added a commit that referenced this issue Oct 16, 2017
@josephduchesne
Merge pull request #35 from avidbots/josephduchesne-patch-1
aecbf5e 
Removed redundant call to resolve #34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robustify