enhancement: allow dynamic content in description and name

[marlena-b]

Description

Fixes #3596

I'm not sure about this solution as there is a lot of metaprogramming that I don't fully understand.
The description already supported lambdas so I just extended it so it now has access to query. I tried to do the same for name but it cannot have access to the query as it is also used to display the text of the tab (see screenshot). When rendering these tabs we don't have access to the query.

I appreciate the feedback, and if this is not the correct way to solve this I don't mind closing this PR :)

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

1. Start the dummy app
2. Open any user
3. Notice the description of Posts relationship has a counter
4. Notice that we use lambda in code to display the name of the relationship

[codeclimate]

Code Climate has analyzed commit cabe522 and detected 0 issues on this pull request.

View more on Code Climate.

[Paul-Bob]

Thank you for this contribution @marlena-b it's already looking great!

I tried to do the same for name but it cannot have access to the query as it is also used to display the text of the tab (see screenshot).

I understand the challenge. Let's keep it without query access for now, and we can iterate on it later if needed.

Let's focus on the name_attributes comment.

Thank you!

[Paul-Bob]

Do we currently have any use for name_attributes? If not, we should consider removing it

def name
  if custom_name?
    Avo::ExecutionContext.new(target: @name).handle
  elsif translation_key
    translated_name default: default_name
  else
    default_name
  end
end

[marlena-b]

I wanted to keep it consistent with how the description attribute is implemented. But I also don't see how this could be used, so I will remove it.

[Paul-Bob]

Got it.

Avo::Concerns::HasDescription is included in multiple classes, some within the avo repository and others across private repositories.

Each class that includes Avo::Concerns::HasDescription can define its own description_attributes. When description is called, description_attributes will vary based on the class from which it is invoked.

For name_attributes, however, we currently don’t have a similar use case.

[Paul-Bob]

I just added a small tweak suggestion, otherwise, it's ready for documentation and merge!

Thanks again, @marlena-b!

[Paul-Bob]

Suggested change

	return Avo::ExecutionContext.new(target: @name).handle
	Avo::ExecutionContext.new(target: @name).handle

We don’t need an explicit return since everything is already wrapped within the if/else condition.

[marlena-b]

I added docs: avo-hq/docs.avohq.io#354

[Paul-Bob]

Awesome!! Thank you!