Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open sln files #116

Merged
merged 4 commits into from
Jul 29, 2020
Merged

Open sln files #116

merged 4 commits into from
Jul 29, 2020

Conversation

henriksen
Copy link
Contributor

@henriksen henriksen commented Jul 29, 2020

Checks the root directory of the repository for *,sln files and adds a "Open " option to the context menu, allowing the user to open the solution directly in Visual Studio.
image

The motivation was that we have several repos and this provides a nice shortcut to finding a repo and opening the solution directly in Visual Studio.

It just starts the file directly since it should be associated with Visual Studio and should open in the correct VS version installed on the user's computer.

I guess it could be expanded on by looking in subfolders (worried about performance), some common subfolders (for instance /src/) or perhaps even some config. Wanted to start small and see if you want this in your app and maybe expand on it later if there's any interest.

Could probably be used on the Mac version as well with Visual Studio for Mac, but I don't have a Mac so I don't know if it would work with just starting the .sln file.

Copy link
Owner

@awaescher awaescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I really really love the idea, thanks for this pull request.
Would you mind to check my review before I merge this?

RepoZ.App.Win/i18n/de-DE.xaml Outdated Show resolved Hide resolved
RepoZ.App.Win/i18n/zh-cn.xaml Show resolved Hide resolved
@henriksen
Copy link
Contributor Author

The Windows CI check is failing since external PRs cannot access CI secrets. Have no idea why the mac CI is failing. Haven't touched the project that's failing there.

@awaescher
Copy link
Owner

The Mac CI build is broken for a while now. Microsoft changed internals in their Mac build hosts, I could not figure out how to solve it yet. Don't mind 🤷

And again, thank you very much 🎉

@awaescher awaescher merged commit 91c690e into awaescher:master Jul 29, 2020
@henriksen henriksen deleted the open_sln_files branch July 29, 2020 10:45
@awaescher
Copy link
Owner

Version 5.4 was just released 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants