Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade deps & localization support #84

Merged
merged 1 commit into from
Sep 4, 2019
Merged

Conversation

pedoc
Copy link
Contributor

@pedoc pedoc commented Aug 27, 2019

upgrade all dependencies over nuget
localization support(en_us & zh_cn)

localization support(en_us & zh_cn)
@awaescher
Copy link
Owner

Thanks for contributing, @pedoc. I'll have a closer look at this soon. Timing's quite perfect, I prepared a release a few days ago.

@awaescher awaescher merged commit 9acfa83 into awaescher:master Sep 4, 2019
@awaescher
Copy link
Owner

Thanks for your contribution, pedoc. Highly appreciated.
I found a few strings which are not translated yet. Would you help me out with a translatin to zh_cn?

@pedoc
Copy link
Contributor Author

pedoc commented Sep 5, 2019

yes,i will reconfirm the string that needs to be translated.

@awaescher
Copy link
Owner

Alright, here we go then. Thanks in advance, mate.

    <system:String x:Key="Open in Windows File Explorer">In Windows Explorer öffnen</system:String>
    <system:String x:Key="Open in Windows PowerShell">In Windows Powershell öffnen</system:String>
    <system:String x:Key="Open in Windows Command Prompt">In Windows Eingabeaufforderung öffnen</system:String>
    <system:String x:Key="Open in Git Bash">In Git Bash öffnen</system:String>
    <system:String x:Key="Fetch">Git Fetch</system:String>
    <system:String x:Key="Pull">Git Pull</system:String>
    <system:String x:Key="Push">Git Push</system:String>
    <system:String x:Key="Checkout">Branch wechseln</system:String>
    <system:String x:Key="Ignore">Ignorieren</system:String>

@pedoc
Copy link
Contributor Author

pedoc commented Sep 12, 2019

@awaescher cool,thanks for u work. plaease review this PR #85

@awaescher
Copy link
Owner

Good day, @pedoc. I have a few more translations for you, sorry.

I already inserted them into the zh-cn.xaml. Would be cool if you could translate them for us. Thanks!

	<system:String x:Key="ScanMac">⚡ Scan mac</system:String>
	<system:String x:Key="Open in Finder">Open in Finder</system:String>
	<system:String x:Key="Open in Terminal">Open in Terminal</system:String>
	<system:String x:Key="Update hint">Version {0} is available.</system:String>

Btw, I removed the emojis in english and german. I suggest you should do in chinese as well if you don't mind.

@awaescher
Copy link
Owner

Any news on this, @pedoc?

@pedoc
Copy link
Contributor Author

pedoc commented Oct 31, 2019

@awaescher sure,but I have been busy recently, so I need some time,sorry.

@awaescher
Copy link
Owner

No problem. Anyways, you can just give me the texts in here, I can put it into the source by myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants