Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen upper dependency bounds #139

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

fiadliel
Copy link
Contributor

@fiadliel fiadliel commented Aug 9, 2020

  • aeson: < 1.5 -> < 1.6
  • base64-bytestring: < 1.1 -> < 1.2
  • QuickCheck: < 2.14 -> < 2.15

(tested with cabal test in nix env)

 - aeson: < 1.5 -> < 1.6
 - base64-bytestring: < 1.1 -> < 1.2
 - QuickCheck: < 2.14 -> < 2.15
@fiadliel
Copy link
Contributor Author

Tests also passed with latest nixpkgs-unstable, packages pinned to latest minor version, and a shell built with nix-shell -p '[ghc cabal-install zlib zlib.dev]'

Due (I think) to sol/doctest#245, I had to add write-ghc-environment-files: always to cabal.project to get doctests to compile.

@rashadg1030
Copy link
Collaborator

rashadg1030 commented Aug 12, 2020

@fiadliel I see this PR has been up for a few days. I'm going to go ahead and merge this unless you want to add anymore to this PR.

@rashadg1030 rashadg1030 merged commit 185517b into awakesecurity:master Aug 12, 2020
@fiadliel fiadliel deleted the widen-deps branch August 27, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants