Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Message instances for wrapped types #162

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

evanrelf
Copy link
Contributor

@evanrelf evanrelf commented Jul 2, 2021

Adds missing Message instances for wrapped types (primitives wrapped by messages in wrappers.proto), enabling the use of wrappers like so:

syntax = "proto3";

package foo;

import "google/protobuf/empty.proto";
import "google/protobuf/wrappers.proto";

service Foo {
  rpc Foo (google.protobuf.Empty) returns (google.protobuf.StringValue);
}

@evanrelf evanrelf requested a review from Gabriella439 July 2, 2021 21:44
@evanrelf evanrelf merged commit 16b60ca into master Jul 8, 2021
@evanrelf evanrelf deleted the evan/unwrapped-message-instances branch July 8, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants