Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create/delete comments #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hasonsk
Copy link
Contributor

@hasonsk hasonsk commented Jan 9, 2025

Attchment link ticket redmine: 82983

Attchment hình ảnh chụp kết quả
image

Attchment hình ảnh chụp layout các chức năng

Mentor vào comment chi tiết một task
image

  • Phía mentee phản hồi
    image

@hasonsk
Copy link
Contributor Author

hasonsk commented Jan 9, 2025

ready

Copy link
Contributor

@anlvq-1058 anlvq-1058 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ủa sao có 2 pull Create/delete comments vậy em

@hasonsk
Copy link
Contributor Author

hasonsk commented Jan 10, 2025

Ủa sao có 2 pull Create/delete comments vậy em

Qua em có đẩy update pull request kia nhưng không thấy có cập nhập trên code REVIEW ạ

@hasonsk hasonsk force-pushed the feature/create-comment branch 2 times, most recently from b6927fa to 8cbbce6 Compare January 10, 2025 02:13
@hasonsk
Copy link
Contributor Author

hasonsk commented Jan 10, 2025

ready

Copy link
Contributor

@anlvq-1058 anlvq-1058 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmt

@@ -1,10 +1,4 @@
class UpdateTasksAndTaskParticipants < ActiveRecord::Migration[7.0]
def change
remove_column :tasks, :creator_id, :bigint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nội dung cũng phải giữ lại chứ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em để nội dung bị dính confict với 20241204235309_create_task_participants.rb do đã tạo column role trước đó.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em không đc sửa file migrate mà. Sao lại bị conflict được

@hasonsk hasonsk force-pushed the feature/create-comment branch from 8cbbce6 to e62df95 Compare January 10, 2025 03:17
@hasonsk hasonsk force-pushed the feature/create-comment branch from e62df95 to aa44440 Compare January 10, 2025 03:38
@hasonsk
Copy link
Contributor Author

hasonsk commented Jan 10, 2025

ready

Copy link
Contributor

@anlvq-1058 anlvq-1058 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmt

@@ -1,10 +1,4 @@
class UpdateTasksAndTaskParticipants < ActiveRecord::Migration[7.0]
def change
remove_column :tasks, :creator_id, :bigint
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Em không đc sửa file migrate mà. Sao lại bị conflict được

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants