Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Feature - Add nofollow + title attribute field for links in Gutenberg Editor #2905

Closed
arnaudbroes opened this issue Sep 13, 2019 · 3 comments
Closed

New Feature - Add nofollow + title attribute field for links in Gutenberg Editor #2905

arnaudbroes opened this issue Sep 13, 2019 · 3 comments
Assignees
@arnaudbroes
Labels
Feature
Milestone
3.4

Comments

@arnaudbroes
Copy link
Contributor

As announced here - https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html

I believe we should be able to do this by adding custom format actions to the editor toolbar.
@arnaudbroes arnaudbroes added this to the 3.3 milestone Sep 13, 2019
@arnaudbroes arnaudbroes self-assigned this Sep 13, 2019
@michaeltorbert
Copy link
Contributor

We should add nofollow to this. Also, we should decide whether to do it as a button or in the little carrot dropdown which has open in a new tab, or both.
Screen Shot 2019-09-13 at 9 44 42 AM

@michaeltorbert
Copy link
Contributor

We'll need classic editor support as well.

@arnaudbroes arnaudbroes modified the milestones: 3.3, 3.4 Sep 17, 2019
@arnaudbroes
Copy link
Contributor Author

WordPress/gutenberg#17556

@arnaudbroes arnaudbroes changed the title New Feature - Add "sponsored" and "ugc" attributes to links New Feature - Add nofollow + title attribute field for Gutenberg Editor Feb 6, 2020
@arnaudbroes arnaudbroes changed the title New Feature - Add nofollow + title attribute field for Gutenberg Editor New Feature - Add nofollow + title attribute field for links in Gutenberg Editor Feb 6, 2020
@arnaudbroes arnaudbroes mentioned this issue Feb 15, 2020
Merged
3 tasks
arnaudbroes added a commit that referenced this issue Mar 11, 2020
@arnaudbroes
Add support for "nofollow" and "sponsored" link attributes (#3138)
be85e17 
* Add link attributes modal for Classic Editor

* PHPCS

* Fix typo

* Add Webpack & Babel

* Add script dev dependencies

* Fix syntax error

* Add custom webpack config file

* Add required ignore entries

* Add support for link attributes for Gutenberg Editor

* Fix script naming

* Improve wording

* Add WP version check for filter

* Fix bug where URL doesn't get copied to modal in Classic Editor

* Change text domain for localized strings

* Fix bug where link attributes are not applied when link is added

* Fix bug where partial nodes wiped search input

* Fix bug where script can't fetch node when anchor is partial string

* Uncomment localized string

* Remove console.log statement

* Align array entry & delete commented localized string

* Update file comment

* Deregister wplink script in core #2905

* Add comments and rename variables #2905

* Lower action priority to override scripts of other plugins #2905

* Revert variable naming changes #2905

* Fix bug in Gutenberg Editor script #2905

* Find anchor of selected text instead of using first anchor #2905

* Format file #2905

* Update Classic Editor script to latest core version #2905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arnaudbroes arnaudbroes

Labels
Feature
Projects
None yet
Milestone
3.4
Development

No branches or pull requests
2 participants
@michaeltorbert @arnaudbroes