Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rapid sending/receiving of messages #16

Merged
merged 1 commit into from
Nov 21, 2019

Conversation

capnspacehook
Copy link
Contributor

This makes the 'Out' channel of each node buffered, by default using a buffer size of 128. The int that specifies the buffer size is exported, so the buffer size is configurable for advanced users.

Copy link
Owner

@awgh awgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a particularly sneaky bug, as non-blocking (select) writes to unbuffered channels silently drop packets, which makes me go insane thinking some algorithm is wrong. This is a totally mandatory change.

@awgh awgh merged commit 99e48c7 into awgh:master Nov 21, 2019
@capnspacehook capnspacehook deleted the out-buffer branch November 21, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants