Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Manual use of Bozja holster items does not go through MAO #543

Open
xanunderscore opened this issue Nov 15, 2024 · 2 comments
Open

Comments

@xanunderscore
Copy link
Collaborator

xanunderscore commented Nov 15, 2024

as discussed on discord, this function

private bool UseBozjaFromHolsterDirectorDetour(PublicContentBozja* self, uint holsterIndex, uint slot)
doesn't call MAO at all, it calls the original director function directly. this results in, e.g., not being able to manually use light curtain if autorotation is on

@xanunderscore
Copy link
Collaborator Author

While debugging this I also discovered that ActionManager->IsRecastTimerActive returns the wrong value if you pass it a bozja holster item, which makes sense, but this means that queueing Light Curtain will result in a lot of log spam since AMEx doesn't know not to try to use it before the GCD is up

@xanunderscore
Copy link
Collaborator Author

updated original comment to link to a specific hash so it doesn't randomly break in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant