added anti knockback abilities #264
Merged
+22
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awgil
reviewed
Feb 12, 2024
BossMod/Components/Knockback.cs
Outdated
| @@ -30,6 +30,7 @@ protected struct PlayerImmuneState | |||
| { | |||
| public DateTime ArmsLengthSurecastExpire; // 0 if not active | |||
| public DateTime InnerStrengthExpire; // 0 if not active | |||
| public DateTime ManawallExpire; // 0 if not active | |||
|
|
|||
| public bool ImmuneAt(DateTime time) => ArmsLengthSurecastExpire > time || InnerStrengthExpire > time; | |||
There was a problem hiding this comment.
You also need to include the check here for it to actually work.
awgil
reviewed
Feb 12, 2024
BossMod/Components/Knockback.cs
Outdated
| @@ -30,6 +30,7 @@ protected struct PlayerImmuneState | |||
| { | |||
| public DateTime ArmsLengthSurecastExpire; // 0 if not active | |||
| public DateTime InnerStrengthExpire; // 0 if not active | |||
| public DateTime ManawallExpire; // 0 if not active | |||
There was a problem hiding this comment.
Maybe rename to [Role/Job/Duty]BuffExpire?
added 3 commits
February 12, 2024 22:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 3 anti knockback abilities to the knockback component. I hope I have done this right and also not forget about any.