monk 3 #363
Merged
monk 3 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
actual rotation improvements: some optimizations for PR/TK blitzes (any form can be used) and smarter default behavior when double lunar is possible, or when starting a fight while already having nadis (happens in dungeons).
mnk is both fortunately and unfortunately an extremely flexible class with inherent cd drift in the optimal rotation, so it's really hard to come up with general purpose strategies for how it should behave. 20 strategy tracks sounds like overkill, and it probably is, but i wasn't able to figure out a simpler way to express some of the strategies such as PB form order. (and yes, i did use all 20 tracks in my DSR and TOP cdplans.) dawntrail will make this entire thing obsolete since the class is drastically being simplified so that's a plus at least. i did my best to include extensive comments in the rotation code to explain the choices i made.