dtr bar display #412
Merged
dtr bar display #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks nice I'll remove the dtrbar from my pull In lieu of yours |
awgil
reviewed
Aug 11, 2024
| @@ -81,6 +82,9 @@ public unsafe Plugin(IDalamudPluginInterface dalamud, ICommandManager commandMan | |||
| _ai = new(_rotation, _amex); | |||
| _broadcast = new(); | |||
| _ipc = new(_rotation, _amex); | |||
| _dtr = new(_rotation); | |||
|
|
|||
| Service.Framework.Update += OnUpdate; | |||
There was a problem hiding this comment.
Why do you need it to happen on framework update, rather than on usual plugin update (which happens during draw)?
There was a problem hiding this comment.
oh no idea I copied this from vnavmesh, i can move it
There was a problem hiding this comment.
When you update it, pls merge to master, i've recently merged other PR which added some dtr stuff, I think it's duplicated now.
|
Updated, I moved herc's DTR bar into this class |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With icon:
without:
umbra version:
popup:
the popup is kind of small but it is the exact same scale as the regular autorotation window - i wonder if it would be a good idea to make it bigger...