navmesh io and compression fix #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awgil
reviewed
Aug 18, 2024
| using var decompressedReader = new BinaryReader(decompressedStream); | ||
|
|
||
| var mesh = DeserializeMesh(decompressedReader); | ||
| var volume = DeserializeVolume(decompressedReader); |
There was a problem hiding this comment.
Oh wow, that's a good catch - so (de)compress streams were created, but not used, lol.
Is there a reason why you did it this way (with extra memory buffer) rather than just passing compressedReader / compressedWriter to the (de)serialize functions?
There was a problem hiding this comment.
Just tried it locally and it seems to work as well btw...
There was a problem hiding this comment.
ah, good catch, i believe i had that before files were truncated to prevent errors
|
Thanks a ton for noticing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two fixes for navmesh files: