feat: inject project info into api overrides #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolk
requested review from
phani-srikar,
sundersc,
AaronZyLee and
alharris-at
sobolk
commented
Mar 27, 2023
Comment on lines
+4
to
+14
| if (!amplifyProjectInfo || !amplifyProjectInfo.envName || !amplifyProjectInfo.projectName) { | ||
| throw new Error(`Project info is missing in override: ${JSON.stringify(amplifyProjectInfo)}`); | ||
| } | ||
|
|
||
| if (amplifyProjectInfo.envName != '##EXPECTED_ENV_NAME') { | ||
| throw new Error(`Received unexpected envName: ${amplifyProjectInfo.envName}`); | ||
| } | ||
|
|
||
| if (amplifyProjectInfo.projectName != '##EXPECTED_PROJECT_NAME') { | ||
| throw new Error(`Received unexpected projectName: ${amplifyProjectInfo.projectName}`); | ||
| } |
There was a problem hiding this comment.
Assertions are injected into override code with placeholders. This is because overrides don't return anything (or even if they do nothing captures return value).
(this pattern is repeated in other tests, with placeholders in e2e tests and hardcoded values in unit tests).
AaronZyLee
reviewed
Mar 27, 2023
There's no action for existing overrides. Additional parameter is ignored at runtime. |
AaronZyLee
approved these changes
Mar 27, 2023
sundersc
approved these changes
Mar 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds additional parameter to the
override()that has environment name and project name.This is a common functionality that has been implemented across other overrides here aws-amplify/amplify-cli#12064 .
Completes coverage for this ask aws-amplify/amplify-cli#9063 .
CDK / CloudFormation Parameters Changed
Issue #, if available
Description of how you validated changes
https://app.circleci.com/pipelines/github/aws-amplify/amplify-category-api?branch=run-e2e%2Fsobkamil%2Finject-project-info
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.