-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight delete confirmation a bit more as warning #6153
Comments
Agree that this is an issue. Let's make the text red and add a " |
Alternative solution that I can come up with is i18n in cli, but it's quite challenging from my experience at npm command to keep time2market fast in upstream. Might be good as long-term goal 🥅 |
@renebrandel Adding of emoji's might be challenging to take into account with our E2E test expect scripts. @ammarkarachi @yuth where all do we need to make changes w.r.t to our E2E tests for this change? |
I just also had a chat with a developer on this now and came up with a |
Three protected (aka locked/unlocked) concept we've discussed before especially for data retention and recreation of tables. That might be the best option here. We will discuss in the new year in depth. |
This issue has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Is your feature request related to a problem? Please describe.
As a developer, I want to be warned a bit more when I run a command that affects production like
amplify delete
so that I can avoid risk in production.Describe the solution you'd like
Highlignt by red for confirmation promp if it affects production. Currently, there is log level from cli perspective and having the similar level for cli users would be quite helpful to avoid the risk that I mentioned in the user story.
The log level in my mind so far is the below:
Red: Affect production
Yellow: Affect the other resources
Green: Affect no resource on AWS
Additional context
I heard from a developer who does not use English as a primary language that they ran
amplify delete
to try deleting an env instead of all hosting service and production was down after. The reason why they ran is because the warning message did not look like dangerous comparing to error message(log level=error). Even the default isNo
and description is clear, making the prompt a bit more noisy is maybe not too much for persona I mentioned, imho.The text was updated successfully, but these errors were encountered: