-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add input validation to SIWA private key prompt #8097
Comments
At least document the format required for the private key. At the moment, the iOS doc does not even mention that part of the CLI. https://docs.amplify.aws/lib/auth/social/q/platform/ios/#launch-social-web-ui-sign-in |
Added an issue on the doc project to document the expected inputs aws-amplify/docs#4678 |
Other issues because of this |
Is this related to a new or existing Amplify category?
auth
Is this related to another service?
n/a
Describe the feature you'd like to request
Add input validation for SIWA private key (PKCS8 PEM format) prompt, preventing developers from adding the social provider and mitigating failed push attempts. Currently providing an invalid value (example:
fakeprivatekey
) will allow a successful update to the local auth resource only to error on push forHostedUIProvidersCustomResourceInputs
, and pointing developers to check the CloudWatch logs for this Lambda callout. This log will display the error:AWS Amplify Admin UI has input validation built into the form used to add SIWA social signin, preventing developers from providing an invalid value. By adding this input validation it will also align DX across Admin UI and the CLI.
Describe the solution you'd like
When providing an invalid private key value such as
fakeprivatekey
CLI should prevent the developer from continuing until a valid private key value (PKCS8 PEM format) is supplied, similar to how the validation error is supplied when adding an APNS notification:Example:
Describe alternatives you've considered
n/a
Additional context
No response
Is this something that you'd be interested in working on?
The text was updated successfully, but these errors were encountered: