chore: Add input validation for private key in oauth flow #11790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Add input validation for private key in sign in with apple oauth flow.
This changes CX a little bit.
Before -> CLI accepts just the key portion OR the key with header and footer as valid input when given without any line breaks, but no input validation since just the
key
cannot be reliably validated with regex.After -> CLI only accepts the private key with header and footer as valid input when given without any line breaks. The input is validated to have the right header and footer.
The obvious benefit of this change is to remove any guesswork on CX to figure out the right format. There are at least 4 different customers who have run into this issue trying to figure out the format (e.g. providing the absolute path to the .p8 file or providing just the key but with line breaks and the prompter just takes the first line as input)
This also brings it in parity with validation in Studio
Issue #, if available
fix: #8097, #9478
Docs PR: aws-amplify/docs#5018
Description of how you validated changes
e2e tests and manually tested the walkthrough for both add and update.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.