feat!: breaking change commit

[akshbhu]

BREAKING CHANGE: convert cli to use cdkV2 library

BREAKING CHANGE: convert cli to use cdkV2 library

Description of changes

• Introduces major version bump for lerna

Issue #, if available

Description of how you validated changes

Checklist

• PR description included
• yarn test passes
• Tests are changed or added
• Relevant documentation is changed or added (and PR referenced)
• New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
• Pull request labels are added

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[edwardfoyle]

LGTM, just make sure that when you merge it, the commit message has the appropriate prefix and suffix to be picked up by lerna

[jhockett]

I think this breaking change commit should touch all packages with breaking changes, Otherwise I'm unsure if lerna will bump all packages correctly.

[akshbhu]

I think this breaking change commit should touch all packages with breaking changes, Otherwise I'm unsure if lerna will bump all packages correctly.

Yeah I am also checking previous PRs , seems like you are right.

[sobolk]

I think this breaking change commit should touch all packages with breaking changes, Otherwise I'm unsure if lerna will bump all packages correctly.

@jhockett is there a way to dry-run learna changes locally ?

[edwardfoyle]

@sobolk yes, run yarn update-versions after making the commit locally

[edwardfoyle]

For the no-op changes in cli-npm and amplify-cli, just add newlines or something else that is clearly a noop like this comment. Otherwise some poor soul 6 months from now might be trying to figure out why disabling a lint rule was a breaking change

[sobolk]

For the no-op changes in cli-npm and amplify-cli, just add newlines or something else that is clearly a noop like this comment. Otherwise some poor soul 6 months from now might be trying to figure out why disabling a lint rule was a breaking change

Or we can add bolded note in PR description about that. Should get recorded when we squash merge this.