Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging dev into feature branch #11827

Merged
merged 52 commits into from
Jan 23, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
9fb23f8
chore: migrate custom category from inquirer to prompter library
pavellazar Dec 28, 2022
5796b4d
chore: Replace inquirer with amplify-prompts in amplify-category-anal…
kuhlmanp Jan 9, 2023
eee32aa
Merge branch 'dev' of https://github.com/kuhlmanp/amplify-cli into dev
kuhlmanp Jan 10, 2023
aba67ff
Merge branch 'aws-amplify:dev' into dev
kuhlmanp Jan 10, 2023
2bd6c9d
fix: custom category prompter tests
pavellazar Jan 10, 2023
629f549
Merge branch 'dev' of https://github.com/kuhlmanp/amplify-cli into dev
kuhlmanp Jan 10, 2023
c7e38e9
Merge branch 'aws-amplify:dev' into dev
kuhlmanp Jan 10, 2023
1a496bd
Merge branch 'dev' of https://github.com/kuhlmanp/amplify-cli into dev
kuhlmanp Jan 10, 2023
ec2aa5c
refactor: clean up dependencies in package.json, update messaging in …
kuhlmanp Jan 10, 2023
fd1eba3
chore: bump codegen version
phani-srikar Jan 9, 2023
1c8fa77
test: update snapshot after codegen version change
phani-srikar Jan 10, 2023
e3c4b63
chore: bump api category dependencies to @aws-amplify/amplify-categor…
alharris-at Jan 12, 2023
fdcb20a
fix: cfn ambda outputs when forcePush flag is used
Jan 9, 2023
0521e96
fix: add to migration test list
Jan 9, 2023
ab11b08
fix: address comments
Jan 9, 2023
cbb63b8
fix: removes git clone windows test
Jan 9, 2023
a7c2863
chore: removes redundant import
Jan 10, 2023
b4089dc
fix: revert windows test
Jan 11, 2023
7727a3f
fix: extract api call
Jan 11, 2023
04424cf
fix: set NoEcho flag on OAuth creds CFN param
edwardfoyle Jan 12, 2023
69fb01c
Merge branch 'aws-amplify:dev' into dev
kuhlmanp Jan 13, 2023
705d223
chore(release): Publish latest [ci skip]
Jan 17, 2023
5beb8b5
Merge pull request #11677 from lazpavel/inquirer-to-prompts-custom-ca…
pavellazar Jan 17, 2023
9eb6a5a
chore: merge release commit from main to dev
danielleadams Jan 17, 2023
dc4e398
ci: e2e multi-core optimizations (#11685)
awsluja Jan 18, 2023
de09228
Merge branch 'aws-amplify:dev' into dev
kuhlmanp Jan 18, 2023
1fc1760
chore: removed overly complicated and confusing logic in pinpoint wal…
kuhlmanp Jan 18, 2023
ce5800a
Merge branch 'dev' of https://github.com/kuhlmanp/amplify-cli into dev
kuhlmanp Jan 18, 2023
d535a3e
ci: windows smoke test list (#11797)
awsluja Jan 18, 2023
de60dde
chore: remove verify-api pre-push hook (#11799)
sdstolworthy Jan 18, 2023
767ece2
Merge branch 'aws-amplify:dev' into dev
kuhlmanp Jan 18, 2023
9352732
fix: remove production env variable from amplify script execution
pavellazar Jan 5, 2023
fadd866
fix: do not overload NODE_ENV env parameter for usage data filtering
pavellazar Jan 18, 2023
6dc26b4
fix: do not overload NODE_ENV env parameter for usage data filtering
pavellazar Jan 18, 2023
6c7ff38
fix: do not overload NODE_ENV env parameter for usage data filtering
pavellazar Jan 18, 2023
d9dfa40
fix: test timeouts on simulator tests (#11804)
sdstolworthy Jan 18, 2023
09bfa2b
ci: fix staleness filters (#11801)
awsluja Jan 18, 2023
9ebfafb
Merge branch 'aws-amplify:dev' into dev
kuhlmanp Jan 18, 2023
4021db3
chore: migrate interactions category from inquirer to prompter library
pavellazar Dec 30, 2022
8208f82
fix: default values for interactions prompter
pavellazar Jan 13, 2023
1506c9b
chore: addressed PR feedback
pavellazar Jan 19, 2023
4ed8dfd
chore: addressed PR feedback
pavellazar Jan 19, 2023
12efd96
Merge pull request #11738 from kuhlmanp/dev
kuhlmanp Jan 19, 2023
be43864
fix: do not overload NODE_ENV env parameter for usage data filtering
pavellazar Jan 19, 2023
b466f4d
chore: Persist downstream exceptions in usage metrics (#11711)
Amplifiyer Jan 19, 2023
e6278b5
chore: Populate cfn exceptions messages in AmplifyFault (#11764)
Amplifiyer Jan 19, 2023
2d072b7
chore: addressed PR feedback
pavellazar Jan 19, 2023
fb7e666
chore: script to allow simple collection of coverage from all project…
sdstolworthy Jan 19, 2023
3501dec
chore: addressed PR feedback
pavellazar Jan 19, 2023
df9c388
chore: migrate interactions category from inquirer to prompter library
pavellazar Jan 19, 2023
5b3adcd
fix: prompt string to match e2e (#11816)
akshbhu Jan 20, 2023
8fccea7
chore: correctly filter failed cfn events for displaying error messag…
Amplifiyer Jan 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 22 additions & 44 deletions .circleci/config.base.yml
Original file line number Diff line number Diff line change
Expand Up @@ -384,25 +384,7 @@ jobs:
command: |
source .circleci/local_publish_helpers.sh
verifyPkgCli

graphql_e2e_tests:
<<: *defaults
steps:
- restore_cache:
key: amplify-cli-repo-{{ .Branch }}-{{ .Revision }}
- restore_cache:
key: amplify-cli-yarn-deps-{{ .Branch }}-{{ checksum "yarn.lock" }}
- run:
name: Run GraphQL end-to-end tests
command: |
source .circleci/local_publish_helpers.sh
cd packages/graphql-transformers-e2e-tests/
retry yarn e2e --maxWorkers=3 $TEST_SUITE
environment:
AMPLIFY_CLI_DISABLE_LOGGING: 'true'
no_output_timeout: 90m
- store_test_results:
path: ~/repo/packages/graphql-transformers-e2e-tests/

amplify_sudo_install_test:
<<: *defaults
steps:
Expand Down Expand Up @@ -490,8 +472,8 @@ jobs:
source .circleci/local_publish_helpers.sh
changeNpmGlobalPath
cd packages/amplify-migration-tests
retry yarn run migration_v5.2.0 --maxWorkers=3 $TEST_SUITE
no_output_timeout: 90m
retry yarn run migration_v5.2.0 --no-cache --maxWorkers= $TEST_SUITE
no_output_timeout: 65m
- run: *scan_e2e_test_artifacts
- store_test_results:
path: ~/repo/packages/amplify-migration-tests/
Expand Down Expand Up @@ -520,8 +502,8 @@ jobs:
source .circleci/local_publish_helpers.sh
changeNpmGlobalPath
cd packages/amplify-migration-tests
retry yarn run migration_v6.1.0 --maxWorkers=3 $TEST_SUITE
no_output_timeout: 90m
retry yarn run migration_v6.1.0 --no-cache --maxWorkers=3 $TEST_SUITE
no_output_timeout: 65m
- run: *scan_e2e_test_artifacts
- store_test_results:
path: ~/repo/packages/amplify-migration-tests/
Expand Down Expand Up @@ -552,8 +534,8 @@ jobs:
cd packages/amplify-migration-tests
unset IS_AMPLIFY_CI
echo $IS_AMPLIFY_CI
retry yarn run migration_v10.5.1 --maxWorkers=3 $TEST_SUITE
no_output_timeout: 90m
retry yarn run migration_v10.5.1 --no-cache --maxWorkers=3 $TEST_SUITE
no_output_timeout: 65m
- run: *scan_e2e_test_artifacts
- store_test_results:
path: ~/repo/packages/amplify-migration-tests/
Expand Down Expand Up @@ -582,7 +564,7 @@ jobs:
source .circleci/local_publish_helpers.sh
changeNpmGlobalPath
cd packages/amplify-migration-tests
retry yarn run migration_v4.28.2_nonmultienv_layers --maxWorkers=3 $TEST_SUITE
retry yarn run migration_v4.28.2_nonmultienv_layers --no-cache --maxWorkers=3 $TEST_SUITE
no_output_timeout: 90m
- run: *scan_e2e_test_artifacts
- store_test_results:
Expand Down Expand Up @@ -612,7 +594,7 @@ jobs:
source .circleci/local_publish_helpers.sh
changeNpmGlobalPath
cd packages/amplify-migration-tests
retry yarn run migration_v4.52.0_multienv_layers --maxWorkers=3 $TEST_SUITE
retry yarn run migration_v4.52.0_multienv_layers --no-cache --maxWorkers=3 $TEST_SUITE
no_output_timeout: 90m
- run: *scan_e2e_test_artifacts
- store_test_results:
Expand Down Expand Up @@ -640,7 +622,7 @@ jobs:
source .circleci/local_publish_helpers.sh
amplify -v
cd packages/amplify-console-integration-tests
retry yarn run console-integration --maxWorkers=3
retry yarn run console-integration --no-cache --maxWorkers=3
name: 'Run Amplify Console integration tests'
no_output_timeout: 90m
- run: *scan_e2e_test_artifacts
Expand Down Expand Up @@ -886,6 +868,13 @@ jobs:
sleep 60
done
no_output_timeout: 180m
- run:
name: 'Collect Results'
command: yarn workflow-results
- run: *scan_e2e_test_artifacts
- store_artifacts:
path: ~/repo/artifacts

working_directory: ~/repo

workflows:
Expand Down Expand Up @@ -947,18 +936,6 @@ workflows:
- beta
- release
- /tagged-release-without-e2e-tests\/.*/
- graphql_e2e_tests:
context:
- e2e-test-context
filters:
branches:
only:
- dev
- /run-e2e-with-rc\/.*/
- /tagged-release\/.*/
- /run-e2e\/.*/
requires:
- upload_pkg_binaries
- integration_test:
context:
- e2e-test-context
Expand Down Expand Up @@ -1184,7 +1161,6 @@ workflows:
requires:
- test
- mock_e2e_tests
- graphql_e2e_tests
- integration_test
- amplify_e2e_tests_pkg
- amplify_sudo_install_test
Expand Down Expand Up @@ -1290,9 +1266,11 @@ commands:
shell: bash.exe
command: |
source .circleci/local_publish_helpers.sh
source $BASH_ENV
amplify version
cd packages/amplify-e2e-tests
retry yarn run e2e --force-exit --detectOpenHandles --maxWorkers=3 $TEST_SUITE
no_output_timeout: 60m
retry yarn run e2e --no-cache --maxWorkers=3 $TEST_SUITE
no_output_timeout: 65m
- when:
condition:
or:
Expand All @@ -1306,7 +1284,7 @@ commands:
source $BASH_ENV
amplify version
retry runE2eTest
no_output_timeout: 90m
no_output_timeout: 65m
scan_e2e_test_artifacts:
description: 'Scan And Cleanup E2E Test Artifacts'
parameters:
Expand Down
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ jobs:
source .circleci/local_publish_helpers.sh
amplify -v
cd packages/amplify-console-integration-tests
retry yarn run console-integration --maxWorkers=3
retry yarn run console-integration --no-cache --maxWorkers=3
name: Run Amplify Console integration tests
no_output_timeout: 90m
- run:
Expand Down
11 changes: 5 additions & 6 deletions .circleci/local_publish_helpers.sh
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,8 @@ function setAwsAccountCredentials {
export AWS_ACCESS_KEY_ID_ORIG=$AWS_ACCESS_KEY_ID
export AWS_SECRET_ACCESS_KEY_ORIG=$AWS_SECRET_ACCESS_KEY
export AWS_SESSION_TOKEN_ORIG=$AWS_SESSION_TOKEN
# introduce a delay of up to 5 minutes to allow for more even spread aws list-accounts calls due to throttling
sleep $[ ( $RANDOM % 300 ) + 1 ]s
# introduce a delay of up to 1 minute to allow for more even spread aws list-accounts calls due to throttling
sleep $[ ( $RANDOM % 60 ) + 1 ]s
if [[ "$OSTYPE" == "msys" ]]; then
# windows provided by circleci has this OSTYPE
useChildAccountCredentials
Expand All @@ -276,11 +276,10 @@ function runE2eTest {

if [ -f $FAILED_TEST_REGEX_FILE ]; then
# read the content of failed tests
failedTests=$(<$FAILED_TEST_REGEX_FILE)
# adding --force-exit per https://github.com/facebook/jest/issues/9473
yarn run e2e --force-exit --detectOpenHandles --maxWorkers=3 $TEST_SUITE -t "$failedTests"
failedTests=$(<$FAILED_TEST_REGEX_FILE)=
yarn run e2e --no-cache --maxWorkers=3 $TEST_SUITE -t "$failedTests"
else
yarn run e2e --force-exit --detectOpenHandles --maxWorkers=3 $TEST_SUITE
yarn run e2e --no-cache --maxWorkers=3 $TEST_SUITE
fi
}

Expand Down
1 change: 1 addition & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ module.exports = {
ecmaVersion: 2020, // Allows for the parsing of modern ECMAScript features
sourceType: 'module', // Allows for the use of imports
project: ['tsconfig.base.json', 'packages/amplify-cli/tsconfig.json'],
tsconfigRootDir: __dirname,
ecmaFeatures: {
jsx: true, // Allows for the parsing of JSX
arrowFunctions: true,
Expand Down
4 changes: 4 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
**/.DS_Store
.circleci/generated_config.yml
scripts/cci-job.data.json
scripts/cci-test.data.json
artifacts/cci-workflow-results.json
artifacts/cci-workflow-results.html
build
!packages/amplify-graphql-model-transformer/src/__tests__/overrides/build/
!packages/amplify-graphql-function-transformer/src/__tests__/overrides/build/
Expand Down
3 changes: 1 addition & 2 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
"files.exclude": {
"**/.git": true,
"**/node_modules": true,
"**/build": true,
"**/coverage": true
"**/build": true
},
"editor.formatOnSave": true,
"eslint.validate": ["javascript", "javascriptreact", "typescript", "typescriptreact"],
Expand Down
3 changes: 3 additions & 0 deletions artifacts/readme.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
CircleCI Workflow results are stored in this artifacts directory.

After each e2e run, you can locate the artifact file here & observe the workflow results summary.
18 changes: 12 additions & 6 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"version": "0.1.0",
"description": "amplify-cli",
"scripts": {
"coverage:collect": "ts-node ./scripts/collect-test-coverage.ts",
"addwords": "node ./scripts/add-to-dict.js",
"test-changed": "nx affected --target=test",
"test": "nx run-many --target=test --all",
Expand All @@ -28,6 +29,8 @@
"link-win": "node ./scripts/link-bin.js packages/amplify-cli/bin/amplify amplify-dev",
"link-aa-win": "node ./scripts/link-bin.js packages/amplify-app/bin/amplify-app amplify-app-dev",
"setup-dev-win": "yarn dev-build && yarn link-win && yarn link-aa-win",
"update-test-timing-data": "ts-node ./scripts/cci-get-job-metrics.ts && ts-node ./scripts/cci-extract-test-timings-from-job-metrics.ts",
"workflow-results": "yarn ts-node ./scripts/cci-workflow-results.ts",
"split-e2e-tests": "yarn ts-node ./scripts/split-e2e-tests.ts && git add .circleci/config.yml",
"verify-commit": "yarn ts-node ./scripts/verify-commit.ts",
"pkg-clean": "rimraf build out pkg/node_modules pkg/yarn.lock",
Expand Down Expand Up @@ -64,7 +67,7 @@
"husky": {
"hooks": {
"commit-msg": "commitlint -E HUSKY_GIT_PARAMS",
"pre-push": "yarn verify-api-extract:clean && yarn build-tests-changed && yarn split-e2e-tests",
"pre-push": "yarn build-tests-changed && yarn split-e2e-tests",
"pre-commit": "yarn verify-commit"
}
},
Expand Down Expand Up @@ -96,7 +99,7 @@
"@commitlint/prompt": "^16.2.3",
"@microsoft/api-extractor": "^7.33.5",
"@types/glob": "^7.1.1",
"@types/jest": "^26.0.20",
"@types/jest": "^27.0.0",
"@types/js-yaml": "^4.0.0",
"@typescript-eslint/eslint-plugin": "^5.34.0",
"@typescript-eslint/parser": "^5.34.0",
Expand All @@ -111,7 +114,7 @@
"eslint-import-resolver-typescript": "^2.0.0",
"eslint-plugin-cypress": "^2.12.1",
"eslint-plugin-import": "^2.22.1",
"eslint-plugin-jest": "^26.1.1",
"eslint-plugin-jest": "^27.0.0",
"eslint-plugin-jsdoc": "^37.9.6",
"eslint-plugin-jsx-a11y": "^6.5.1",
"eslint-plugin-prefer-arrow": "^1.2.3",
Expand All @@ -120,8 +123,11 @@
"execa": "^5.1.1",
"glob": "^7.2.0",
"husky": "^3.1.0",
"jest": "^26.6.3",
"jest-circus": "^26.6.3",
"istanbul-lib-coverage": "^3.2.0",
"istanbul-lib-report": "^3.0.0",
"istanbul-reports": "^3.1.5",
"jest": "^27.0.0",
"jest-circus": "^27.0.0",
"jest-junit": "^12.0.0",
"js-yaml": "^4.0.0",
"lnk": "1.1.0",
Expand All @@ -130,7 +136,7 @@
"nx": "^14.8.3",
"pkg": "^5.4.1",
"rimraf": "^3.0.0",
"ts-jest": "^26.4.4",
"ts-jest": "^27.0.0",
"ts-node": "^8.10.1",
"typescript": "^4.5.5"
},
Expand Down
8 changes: 8 additions & 0 deletions packages/amplify-app/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.3.7](https://github.com/aws-amplify/amplify-cli/compare/[email protected]@4.3.7) (2023-01-17)

**Note:** Version bump only for package amplify-app





## [4.3.6](https://github.com/aws-amplify/amplify-cli/compare/[email protected]@4.3.6) (2023-01-03)

**Note:** Version bump only for package amplify-app
Expand Down
6 changes: 3 additions & 3 deletions packages/amplify-app/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "amplify-app",
"version": "4.3.6",
"version": "4.3.7",
"description": "Amplify CLI",
"repository": {
"type": "git",
Expand Down Expand Up @@ -30,8 +30,8 @@
"dependencies": {
"amplify-frontend-android": "3.4.0",
"amplify-frontend-flutter": "1.3.5",
"amplify-frontend-ios": "3.5.6",
"amplify-frontend-javascript": "3.7.2",
"amplify-frontend-ios": "3.5.7",
"amplify-frontend-javascript": "3.7.3",
"chalk": "^4.1.1",
"execa": "^5.1.1",
"fs-extra": "^8.1.0",
Expand Down
8 changes: 8 additions & 0 deletions packages/amplify-appsync-simulator/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [2.9.1](https://github.com/aws-amplify/amplify-cli/compare/@aws-amplify/[email protected]...@aws-amplify/[email protected]) (2023-01-17)

**Note:** Version bump only for package @aws-amplify/amplify-appsync-simulator





# [2.9.0](https://github.com/aws-amplify/amplify-cli/compare/@aws-amplify/[email protected]...@aws-amplify/[email protected]) (2023-01-03)


Expand Down
4 changes: 2 additions & 2 deletions packages/amplify-appsync-simulator/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@aws-amplify/amplify-appsync-simulator",
"version": "2.9.0",
"version": "2.9.1",
"description": "An AppSync Simulator to test AppSync API.",
"repository": {
"type": "git",
Expand Down Expand Up @@ -32,7 +32,7 @@
"dependencies": {
"@graphql-tools/schema": "^8.3.1",
"@graphql-tools/utils": "^8.5.1",
"amplify-cli-core": "3.5.0",
"amplify-cli-core": "3.5.1",
"amplify-prompts": "2.6.2",
"amplify-velocity-template": "1.4.8",
"aws-sdk": "^2.1233.0",
Expand Down
8 changes: 8 additions & 0 deletions packages/amplify-category-analytics/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

## [4.3.1](https://github.com/aws-amplify/amplify-cli/compare/[email protected]@4.3.1) (2023-01-17)

**Note:** Version bump only for package amplify-category-analytics





# [4.3.0](https://github.com/aws-amplify/amplify-cli/compare/[email protected]@4.3.0) (2023-01-03)


Expand Down
7 changes: 3 additions & 4 deletions packages/amplify-category-analytics/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "amplify-category-analytics",
"version": "4.3.0",
"version": "4.3.1",
"description": "amplify-cli analytics plugin",
"repository": {
"type": "git",
Expand All @@ -22,11 +22,10 @@
"extract-api": "ts-node ../../scripts/extract-api.ts"
},
"dependencies": {
"@aws-amplify/amplify-environment-parameters": "1.3.0",
"amplify-cli-core": "3.5.0",
"@aws-amplify/amplify-environment-parameters": "1.3.1",
"amplify-cli-core": "3.5.1",
"amplify-prompts": "2.6.2",
"fs-extra": "^8.1.0",
"inquirer": "^7.3.3",
"uuid": "^8.3.2"
},
"jest": {
Expand Down
Loading