fix: store email channel role arn to amplify meta output #11883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
lazpavel
commented
Feb 1, 2023
| @@ -69,7 +69,10 @@ export const enable = async (context:$TSContext, successMessage: string|undefine | |||
| try { | |||
| const data = await context.exeInfo.pinpointClient.updateEmailChannel(params).promise(); | |||
| spinner.succeed(successMessage ?? `The ${channelName} channel has been successfully enabled.`); | |||
| context.exeInfo.serviceMeta.output[channelName] = data.EmailChannelResponse; | |||
| context.exeInfo.serviceMeta.output[channelName] = { | |||
| RoleArn: params.EmailChannelRequest.RoleArn, | |||
There was a problem hiding this comment.
1/2 change in the file is setting the RoleArn from the input parameters, this issue is caused by a bug in the pinpoint CDK not returning the RoleArn in the EmailChannelResponse body as stated in this documentation. Filed a ticket against Pinpoint CDK and this change is meant to be a temporary workaround until the root cause is being fixed
There was a problem hiding this comment.
Can we do like below if the pinpoint cdk returning undefined or null
Suggested change
| RoleArn: params.EmailChannelRequest.RoleArn, | |
| RoleArn: data.EmailChannelResponse ?? params.EmailChannelRequest.RoleArn, |
There was a problem hiding this comment.
If the roleArn is an optional field, will it cause problem to send a null or empty string here?
lazpavel
commented
Feb 1, 2023
| const validateInputParams = (channelInput: $TSAny) : $TSAny => { | ||
| if (!channelInput.FromAddress || !channelInput.Identity || !channelInput.RoleArn) { | ||
| const validateInputParams = (channelInput: $TSAny): $TSAny => { | ||
| if (!channelInput.FromAddress || !channelInput.Identity) { |
There was a problem hiding this comment.
2/2 change of the file. RoleArn is an optional field.
aws-eddy
approved these changes
Feb 1, 2023
sobolk
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #11819
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.