Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace role map lambda with cfn code #12231

Merged
merged 28 commits into from
Apr 7, 2023
Merged

feat: replace role map lambda with cfn code #12231

Show file tree
Hide file tree
Changes from 26 commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3d97442
chore: add role mappings to role attachment for user pool clients
danielleadams Mar 14, 2023
a1c52e6
chore: add get identity pool roles helper to e2e helpers
danielleadams Mar 14, 2023
e68201f
test: add e2e test to test identity role mappings
danielleadams Mar 15, 2023
01f709b
refactor: remove role map lambda
danielleadams Mar 15, 2023
aa38bc0
test: add migration e2e test for role settings
danielleadams Mar 16, 2023
63fcd8e
test: remove unused import
danielleadams Mar 16, 2023
557855a
test: add migration test for roles
danielleadams Mar 16, 2023
60a6a1b
test: update snapshots
danielleadams Mar 17, 2023
31d4c1a
fix: add depends on with user pool groups
danielleadams Mar 17, 2023
6de92fe
fix: fix linting warnings
danielleadams Mar 17, 2023
1b09134
fix: fix prettier errors
danielleadams Mar 17, 2023
bb1c4ef
test: fix snapshot role attachments only included with user groups
danielleadams Mar 17, 2023
a1b8d5e
fix: remove empty object from cfn input
danielleadams Mar 17, 2023
5dd12d9
fix: remove promise callback from chain
danielleadams Mar 17, 2023
71b5698
test: fix snapshot
danielleadams Mar 17, 2023
0df0656
fix: fix linting warnings/errors
danielleadams Mar 17, 2023
61be25a
test: fix e2e test and add additional test
danielleadams Mar 21, 2023
c117f63
fix: lint
danielleadams Mar 23, 2023
1af9787
test: update snapshot for auth add all migration
danielleadams Mar 23, 2023
ebcffba
test: update snapshot to remove lambda artifacts
danielleadams Mar 24, 2023
616e21c
test: add additional e2e test for update
danielleadams Mar 24, 2023
91404f0
chore: update geo snapshot
sobolk Mar 24, 2023
13a8b68
fix: update cognito stack on user pool group update
danielleadams Mar 27, 2023
4dbd02e
fix: use boolean when creating role maps
danielleadams Mar 27, 2023
b0abaf6
test: update snapshot to reflect added role attachments
danielleadams Mar 28, 2023
12fea34
test: invoke cognito with region
danielleadams Mar 29, 2023
9435bce
Merge branch 'feat/replace-lambda-callouts' into feat/replace-role-ma…
danielleadams Apr 4, 2023
6126e0f
Merge branch 'feat/replace-lambda-callouts' into feat/replace-role-ma…
danielleadams Apr 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions packages/amplify-category-auth/resources/auth-custom-resource/role-map-lambda-function.js
View file
Open in desktop

This file was deleted.

44 changes: 44 additions & 0 deletions ...tils/awscloudformation/auth-stack-builder/__snapshots__/auth-stack-transform.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1538,11 +1538,55 @@ exports.handler = (event, context, callback) => {
"IdentityPoolRoleMap": Object {
"DependsOn": Array [
"IdentityPool",
"UserPoolClient",
"UserPoolClientWeb",
],
"Properties": Object {
"IdentityPoolId": Object {
"Ref": "IdentityPool",
},
"RoleMappings": Object {
"UserPoolClientRoleMapping": Object {
"AmbiguousRoleResolution": "AuthenticatedRole",
"IdentityProvider": Object {
"Fn::Sub": Array [
"cognito-idp.\${region}.amazonaws.com/\${userPool}:\${client}",
Object {
"client": Object {
"Ref": "UserPoolClient",
},
"region": Object {
"Ref": "AWS::Region",
},
"userPool": Object {
"Ref": "UserPool",
},
},
],
},
"Type": "Token",
},
"UserPoolWebClientRoleMapping": Object {
"AmbiguousRoleResolution": "AuthenticatedRole",
"IdentityProvider": Object {
"Fn::Sub": Array [
"cognito-idp.\${region}.amazonaws.com/\${userPool}:\${webClient}",
Object {
"region": Object {
"Ref": "AWS::Region",
},
"userPool": Object {
"Ref": "UserPool",
},
"webClient": Object {
"Ref": "UserPoolClientWeb",
},
},
],
},
"Type": "Token",
},
},
"Roles": Object {
"authenticated": Object {
"Ref": "authRoleArn",
Expand Down
Loading