Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reclassify BucketNotExists error during init-env #12399

Merged
merged 3 commits into from
Apr 6, 2023
Merged

fix: reclassify BucketNotExists error during init-env #12399

merged 3 commits into from
Apr 6, 2023

Conversation

edwardfoyle
Copy link
Contributor

Description of changes

Catches BucketNotExists exceptions that occur when trying to fetch contents from the deployment bucket on initialize environment operations and reclassifies these exceptions as AmplifyError with some additional recovery instructions

Issue #, if available

Description of how you validated changes

Manually verified, e2e tests pass and added unit tests

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@edwardfoyle edwardfoyle requested a review from a team as a code owner April 6, 2023 18:28
@edwardfoyle edwardfoyle merged commit 3dbc548 into aws-amplify:dev Apr 6, 2023
aws-eddy pushed a commit to aws-eddy/amplify-cli that referenced this pull request Apr 7, 2023
@edwardfoyle @aws-eddy
fix: reclassify BucketNotExists error during init-env (aws-amplify#12399
7cd5d27 
)
aws-eddy added a commit that referenced this pull request Apr 7, 2023
@aws-eddy @hein-j
@sobolk @Amplifiyer @edwardfoyle @sdstolworthy
chore: complete cli core migration (#12408)
7eaeeaa 
* chore: complete prefixing cli-core migration

* chore: generate api extract and sort package.json

* feat(amplify-util-uibuilder): support StorageField (#12386)

* feat((amplify-util-uibuilder): support StorageField

* chore: update all aws-sdk versions to ^2.1350.0

* fix: revert changes to package.json.ejs

* chore: add **/aws-sdk to package.json under resolutions

* fix: revert white space changes in package.json.ejs

* fix: bump codegen-ui to 2.12.1

* chore: bump lint memory

---------

Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Kamil Sobol <[email protected]>

* chore: reclassify CFN deployment errors if all the errors are from custom resources (#12398)

* chore: reclassify CFN deployment errors if all the errors are from custom resources

* fix: run prettier

* fix: correctly scope amplify-cli-core

* fix: pr review updates

* fix: reclassify BucketNotExists error during init-env (#12399)

* feat: create new NodeJS functions with nodejs18.x runtime (#12394)

* chore: use node 18 in the packaged cli

* chore: force prebuild-install to 7.11

* chore: try update

* Revert "chore: try update"

This reverts commit 6332c61.

* chore: disable deprecation flags

* chore: try node18 image

* chore: more memory

* chore: less parallelization

* chore: try newer windows

* Revert "chore: try newer windows"

This reverts commit 59d5e6d.

* chore: install node 18 on windows

* chore: install node 18 on windows

* chore: try this

* chore: try this

* chore: try this

* chore: try this

* Revert "Revert "chore: try newer windows""

This reverts commit dcac927.

* chore: try this

* chore: try this

* chore: consolidate steps

* chore: parallel in UT

* chore: parallel in UT

* chore: remove dotnet migration test

* chore: fix results script

* chore: fix dotnet

* chore: install create react app

* chore: allow old ssl

* Revert "chore: allow old ssl"

This reverts commit 08d03f9.

* chore: use new react scripts

* chore: poke ci

* chore: fix init test

* chore: use usual ECR repo

* chore: use previous windows image

* Revert "chore: use previous windows image"

This reverts commit f3299f1.

* chore: update pkg

* chore: remove sequential promise

* chore: run this in us west

* Revert "chore: remove sequential promise"

This reverts commit f053413.

* chore: wait for selection

* chore: wait for selection

* chore: wait for selection

* chore: wait for choice first

* feat: generate nodejs18 lambdas

* chore: dont use modules

* chore: undo that

* chore: make crud work

* chore: fix test

* chore: fix that test

* chore: refactor imports

* chore: fix test

* chore: fix test

* chore: fix test

* chore: fix test

* chore: fix test

* chore: add nodejs12.x to migrate from

* chore: fix test

* chore: fix test

* chore: test nodejs crud

* chore: update tests

* chore: pr feedback

* fix: block auth w/ triggers push if not migrated to cli-inputs (#12337)

* fix: catch undefined LogicalName when Lambda Layer versions are deleted from the console (#12351)

* fix: throw a descriptive AmplifyError when an existing lambda layer LogicalName is undefined

* chore: migrate missing files

* chore: fixing failing tests

* chore: sort package.json

* chore: complete prefixing cli-core migration

* chore: regenerate yarn.lock and address codeQL warnings

* chore: lint file

---------

Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Kamil Sobol <[email protected]>
Co-authored-by: Amplifiyer <[email protected]>
Co-authored-by: Edward Foyle <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
aws-eddy added a commit to aws-eddy/amplify-cli that referenced this pull request Apr 10, 2023
@aws-eddy @hein-j
@sobolk @Amplifiyer @edwardfoyle @sdstolworthy
chore: complete cli core migration (aws-amplify#12408)
b830929 
* chore: complete prefixing cli-core migration

* chore: generate api extract and sort package.json

* feat(amplify-util-uibuilder): support StorageField (aws-amplify#12386)

* feat((amplify-util-uibuilder): support StorageField

* chore: update all aws-sdk versions to ^2.1350.0

* fix: revert changes to package.json.ejs

* chore: add **/aws-sdk to package.json under resolutions

* fix: revert white space changes in package.json.ejs

* fix: bump codegen-ui to 2.12.1

* chore: bump lint memory

---------

Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Kamil Sobol <[email protected]>

* chore: reclassify CFN deployment errors if all the errors are from custom resources (aws-amplify#12398)

* chore: reclassify CFN deployment errors if all the errors are from custom resources

* fix: run prettier

* fix: correctly scope amplify-cli-core

* fix: pr review updates

* fix: reclassify BucketNotExists error during init-env (aws-amplify#12399)

* feat: create new NodeJS functions with nodejs18.x runtime (aws-amplify#12394)

* chore: use node 18 in the packaged cli

* chore: force prebuild-install to 7.11

* chore: try update

* Revert "chore: try update"

This reverts commit 6332c61.

* chore: disable deprecation flags

* chore: try node18 image

* chore: more memory

* chore: less parallelization

* chore: try newer windows

* Revert "chore: try newer windows"

This reverts commit 59d5e6d.

* chore: install node 18 on windows

* chore: install node 18 on windows

* chore: try this

* chore: try this

* chore: try this

* chore: try this

* Revert "Revert "chore: try newer windows""

This reverts commit dcac927.

* chore: try this

* chore: try this

* chore: consolidate steps

* chore: parallel in UT

* chore: parallel in UT

* chore: remove dotnet migration test

* chore: fix results script

* chore: fix dotnet

* chore: install create react app

* chore: allow old ssl

* Revert "chore: allow old ssl"

This reverts commit 08d03f9.

* chore: use new react scripts

* chore: poke ci

* chore: fix init test

* chore: use usual ECR repo

* chore: use previous windows image

* Revert "chore: use previous windows image"

This reverts commit f3299f1.

* chore: update pkg

* chore: remove sequential promise

* chore: run this in us west

* Revert "chore: remove sequential promise"

This reverts commit f053413.

* chore: wait for selection

* chore: wait for selection

* chore: wait for selection

* chore: wait for choice first

* feat: generate nodejs18 lambdas

* chore: dont use modules

* chore: undo that

* chore: make crud work

* chore: fix test

* chore: fix that test

* chore: refactor imports

* chore: fix test

* chore: fix test

* chore: fix test

* chore: fix test

* chore: fix test

* chore: add nodejs12.x to migrate from

* chore: fix test

* chore: fix test

* chore: test nodejs crud

* chore: update tests

* chore: pr feedback

* fix: block auth w/ triggers push if not migrated to cli-inputs (aws-amplify#12337)

* fix: catch undefined LogicalName when Lambda Layer versions are deleted from the console (aws-amplify#12351)

* fix: throw a descriptive AmplifyError when an existing lambda layer LogicalName is undefined

* chore: migrate missing files

* chore: fixing failing tests

* chore: sort package.json

* chore: complete prefixing cli-core migration

* chore: regenerate yarn.lock and address codeQL warnings

* chore: lint file

---------

Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Kamil Sobol <[email protected]>
Co-authored-by: Amplifiyer <[email protected]>
Co-authored-by: Edward Foyle <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
aws-eddy added a commit to aws-eddy/amplify-cli that referenced this pull request Apr 11, 2023
@aws-eddy @hein-j
@sobolk @Amplifiyer @edwardfoyle @sdstolworthy
chore: complete cli core migration (aws-amplify#12408)
92370a2 
* chore: complete prefixing cli-core migration

* chore: generate api extract and sort package.json

* feat(amplify-util-uibuilder): support StorageField (aws-amplify#12386)

* feat((amplify-util-uibuilder): support StorageField

* chore: update all aws-sdk versions to ^2.1350.0

* fix: revert changes to package.json.ejs

* chore: add **/aws-sdk to package.json under resolutions

* fix: revert white space changes in package.json.ejs

* fix: bump codegen-ui to 2.12.1

* chore: bump lint memory

---------

Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Kamil Sobol <[email protected]>

* chore: reclassify CFN deployment errors if all the errors are from custom resources (aws-amplify#12398)

* chore: reclassify CFN deployment errors if all the errors are from custom resources

* fix: run prettier

* fix: correctly scope amplify-cli-core

* fix: pr review updates

* fix: reclassify BucketNotExists error during init-env (aws-amplify#12399)

* feat: create new NodeJS functions with nodejs18.x runtime (aws-amplify#12394)

* chore: use node 18 in the packaged cli

* chore: force prebuild-install to 7.11

* chore: try update

* Revert "chore: try update"

This reverts commit 6332c61.

* chore: disable deprecation flags

* chore: try node18 image

* chore: more memory

* chore: less parallelization

* chore: try newer windows

* Revert "chore: try newer windows"

This reverts commit 59d5e6d.

* chore: install node 18 on windows

* chore: install node 18 on windows

* chore: try this

* chore: try this

* chore: try this

* chore: try this

* Revert "Revert "chore: try newer windows""

This reverts commit dcac927.

* chore: try this

* chore: try this

* chore: consolidate steps

* chore: parallel in UT

* chore: parallel in UT

* chore: remove dotnet migration test

* chore: fix results script

* chore: fix dotnet

* chore: install create react app

* chore: allow old ssl

* Revert "chore: allow old ssl"

This reverts commit 08d03f9.

* chore: use new react scripts

* chore: poke ci

* chore: fix init test

* chore: use usual ECR repo

* chore: use previous windows image

* Revert "chore: use previous windows image"

This reverts commit f3299f1.

* chore: update pkg

* chore: remove sequential promise

* chore: run this in us west

* Revert "chore: remove sequential promise"

This reverts commit f053413.

* chore: wait for selection

* chore: wait for selection

* chore: wait for selection

* chore: wait for choice first

* feat: generate nodejs18 lambdas

* chore: dont use modules

* chore: undo that

* chore: make crud work

* chore: fix test

* chore: fix that test

* chore: refactor imports

* chore: fix test

* chore: fix test

* chore: fix test

* chore: fix test

* chore: fix test

* chore: add nodejs12.x to migrate from

* chore: fix test

* chore: fix test

* chore: test nodejs crud

* chore: update tests

* chore: pr feedback

* fix: block auth w/ triggers push if not migrated to cli-inputs (aws-amplify#12337)

* fix: catch undefined LogicalName when Lambda Layer versions are deleted from the console (aws-amplify#12351)

* fix: throw a descriptive AmplifyError when an existing lambda layer LogicalName is undefined

* chore: migrate missing files

* chore: fixing failing tests

* chore: sort package.json

* chore: complete prefixing cli-core migration

* chore: regenerate yarn.lock and address codeQL warnings

* chore: lint file

---------

Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Hein Jeong <[email protected]>
Co-authored-by: Kamil Sobol <[email protected]>
Co-authored-by: Amplifiyer <[email protected]>
Co-authored-by: Edward Foyle <[email protected]>
Co-authored-by: Spencer Stolworthy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amplifiyer Amplifiyer Amplifiyer approved these changes

@sobolk sobolk sobolk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edwardfoyle @sobolk @Amplifiyer