chore: refactor to use showApiAuthAcm from API Category #12484
Merged
+12
−871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alharris-at
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
@alharris-at is this PR still on hold?
|
danielleadams
added
the
do-not-merge
alharris-at
force-pushed
the
use-api-category-acm
branch
from
cc83104 to
a25ec17
Compare
alharris-at
changed the title
alharris-at
removed
the
do-not-merge
alharris-at
force-pushed
the
use-api-category-acm
branch
4 times, most recently
from
1f1d4bf to
fdd580f
Compare
phani-srikar
previously approved these changes
May 26, 2023
dpilch
previously approved these changes
May 26, 2023
alharris-at
force-pushed
the
use-api-category-acm
branch
from
fdd580f to
979ed06
Compare
dpilch
approved these changes
May 26, 2023
sobolk
approved these changes
May 26, 2023
Comment on lines
-68
to
-69
| "@aws-amplify/graphql-auth-transformer": "^2.1.5", | ||
| "@aws-amplify/graphql-transformer-core": "^1.3.1", |
| @@ -1,14 +1,12 @@ | |||
| import { stateManager, pathManager } from '@aws-amplify/amplify-cli-core'; | |||
| import { readProjectSchema } from 'graphql-transformer-core'; | |||
| import { showApiAuthAcm } from '@aws-amplify/amplify-category-api'; | |||
There was a problem hiding this comment.
what's Acm ? public apis should avoid acronyms of possible.
(for the record - it seems this has shipped already)
| import { getProviderPlugins } from './get-provider-plugins'; | ||
| import { getProjectConfig } from './get-project-config'; | ||
|
|
||
| import { checkForcedUpdates as checkApiForcedUpdates } from '@aws-amplify/amplify-category-api'; |
There was a problem hiding this comment.
thought for future. if we ever get to ApiCategory implements ICategory then there should be ICategory.checkForcedUpdate with default no op impl. or some cross cutting mechanism.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Breaking direct dependencies from Amplify CLI on transformer packages. There's a bit more to do, but this addresses auth and one of the core packages.
Issue #, if available
N/A
Description of how you validated changes
Tests/E2E Tests
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.